Add Tahoma scenes #12498
Merged
Add Tahoma scenes #12498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Feb 18, 2018
homeassistant/components/tahoma.py
Outdated
| except RequestException: | ||
| _LOGGER.exception("Error when getting devices from the Tahoma API") | ||
| return False | ||
|
|
||
| hass.data[DOMAIN] = { | ||
| 'controller': api, | ||
| 'devices': defaultdict(list) | ||
| 'devices': defaultdict(list), | ||
| 'scenes':[] |
| self._name = self.tahoma_scene.name | ||
|
|
||
|
|
||
| def activate(self, **kwargs): |
2 tasks
|
tahoma-api has been updated to 0.0.12, this is now ready to be reviewed / merged 👍 |
balloob
pushed a commit
that referenced
this pull request
Feb 25, 2018
* add scenes to platform * add scene.tahoma * requires tahoma-api 0.0.12 * update requirements_all.txt * hound * fix pylint error
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This adds scenarios from Tahoma into HomeAssistant! Upon restart of HomeAssistant they will automatically be added to your setup!
Finally got around to implementing these scenes from the Tahoma component. They can be added in the Tahoma interface. This cuts down on API calls is a big way. Now only 1 call is needed to move any amount of covers!
This has been running in my own setup for a couple of days, it works great.
Also fixes #12516
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#4698
Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests pass