Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zha: Simplify unique ID #12495

Merged
merged 1 commit into from
Feb 18, 2018
Merged

zha: Simplify unique ID #12495

merged 1 commit into from
Feb 18, 2018

Conversation

rcloran
Copy link
Contributor

@rcloran rcloran commented Feb 18, 2018

It turns out we were already calculating exactly the same thing. This also fixes entity IDs generated for devices on the same endpoint.

Description:

Related issue (if applicable): fixes #

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

Also fixes entity IDs generated for devices on the same endpoint.
@balloob balloob merged commit 17b5709 into home-assistant:dev Feb 18, 2018
dmulcahey pushed a commit to dmulcahey/home-assistant that referenced this pull request Feb 19, 2018
Also fixes entity IDs generated for devices on the same endpoint.
@balloob balloob mentioned this pull request Feb 22, 2018
@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed integration: zha small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants