Try deflaking recorder tests #12492
Merged
Try deflaking recorder tests #12492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
cla-signed
integration: recorder
core
small-pr
houndci-bot
reviewed
Feb 18, 2018
| @@ -7,7 +7,7 @@ | |||
|
|
|||
| from homeassistant.core import callback | |||
| from homeassistant.const import MATCH_ALL | |||
| from homeassistant.components.recorder import Recorder | |||
| from homeassistant.components.recorder import Recorder, wait_connection_ready | |||
There was a problem hiding this comment.
'homeassistant.components.recorder.wait_connection_ready' imported but unused
|
I've had like 6 successful runs on Py34 now (restarted a few times). I'm going to merge this and celebrate. |
dmulcahey
pushed a commit
to dmulcahey/home-assistant
that referenced
this pull request
Feb 19, 2018
* Try deflaking recorder tests * Remove run_coroutine_threadsafe * Lint
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I have run this branch 3 times on Travis and 0 failures. I think that it is due to giving some other code longer to initialize.
Related issue (if applicable): flaky tests!!