KNX/Climate: Fixed platform schema min/max values. #12477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…IFT_MIN and CONF_SETPOINT_SHIFT_MAX
homeassistant
added
platform: climate.knx
small-pr
Julius2342
changed the title
balloob
requested changes
Feb 17, 2018
| @@ -48,9 +48,9 @@ | |||
| default=DEFAULT_SETPOINT_SHIFT_STEP): vol.All( | |||
| float, vol.Range(min=0, max=2)), | |||
| vol.Optional(CONF_SETPOINT_SHIFT_MAX): | |||
| vol.All(int, vol.Range(min=-32, max=0)), | |||
There was a problem hiding this comment.
Can you move the defaults back into the schema? I moved them to the setup and pass then in as second argument to get because defaults weren't valid values
balloob
approved these changes
Feb 17, 2018
Merged
ghost
added
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in a in a reviewcomment by @balloob : fixed min/max values of CONF_SETPOINT_SHIFT_MAX and CONF_SETPOINT_SHIFT_MIN within platform schema.