Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQL Sensor] always close session #12452

Merged
merged 2 commits into from
Feb 16, 2018
Merged

Conversation

dgomes
Copy link
Contributor

@dgomes dgomes commented Feb 15, 2018

Description:

I spotted an obvious mistake 🤡

Checklist:

  • The code change is tested and works locally.
  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass

@dgomes dgomes closed this Feb 16, 2018
@dgomes dgomes reopened this Feb 16, 2018
@balloob balloob added this to the 0.63.3 milestone Feb 16, 2018
@balloob balloob merged commit d43a8e5 into home-assistant:dev Feb 16, 2018
balloob pushed a commit that referenced this pull request Feb 17, 2018
* close aborted session

* blank line
@balloob balloob mentioned this pull request Feb 17, 2018
dgomes added a commit to dgomes/home-assistant that referenced this pull request Mar 6, 2018
balloob pushed a commit that referenced this pull request Mar 7, 2018
* partial revert of #12452

* return missing
@balloob balloob mentioned this pull request Mar 9, 2018
@dgomes dgomes deleted the sensor.sql.fix.1 branch March 26, 2018 16:01
@home-assistant home-assistant locked and limited conversation to collaborators Jul 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed integration: sql small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants