Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MQTT payload decode returning prematurely #12420

Merged
merged 2 commits into from
Feb 15, 2018
Merged

Fix MQTT payload decode returning prematurely #12420

merged 2 commits into from
Feb 15, 2018

Conversation

OttoWinter
Copy link
Member

Description:

Follow-up on #12004 - the code there had a bug that could potentially prevent subscription callbacks from being run.

Example entry for configuration.yaml (if applicable):

mqtt:
  broker: the.broker.com

Checklist:

  • The code change is tested and works locally.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@OttoWinter OttoWinter requested a review from a team as a code owner February 14, 2018 22:59
@balloob balloob merged commit 5d4b1ec into home-assistant:dev Feb 15, 2018
@OttoWinter OttoWinter deleted the mqtt-return branch February 18, 2018 09:48
@balloob balloob mentioned this pull request Feb 22, 2018
Merged
@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
cla-signed core integration: mqtt small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OttoWinter @balloob @homeassistant