Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small code cleanup within scenes #12409

Merged
merged 2 commits into from
Feb 15, 2018

Conversation

Julius2342
Copy link
Contributor

Description:

  • should_poll of base class already returns False
  • there is no is_on within Scene

- should_poll of base class already returns False
- there is no is_on within Scene
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@balloob balloob merged commit f5d1f53 into home-assistant:dev Feb 15, 2018
@balloob
Copy link
Member

balloob commented Feb 15, 2018

History note: we used to be able to turn off scenes. I wrote some complicated logic that would allow a scene to be "undone". It would try to change the states back to the state before the scene was turned on. A scene was considered "on" when the devices would match state/attributes with the scene.

However, this would only work if the device would report the state exactly as we wanted it to set from the initial scene. I quickly realized that this would not work with things like X, Y color for Hue. The reported value always differs from the command.

I decided to remove the feature but it looks like some things stuck around. Thanks for cleaning this up.

@balloob balloob mentioned this pull request Feb 22, 2018
@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants