Code cleanup of velux scene #12390
Merged
Code cleanup of velux scene #12390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
cla-signed
integration: scene
core
small-pr
balloob
reviewed
Feb 14, 2018
| """Activate the scene.""" | ||
| self.hass.async_add_job(self.scene.run()) | ||
| yield from self.scene.run() |
There was a problem hiding this comment.
MartinHjelmare
requested changes
Feb 14, 2018
There was a problem hiding this comment.
Also please remove unnecessary return from setup_platform.
After this cleanup, the velux component can also be cleaned up, eg by removing the initialized and hassattributes.
Does this have anything to do with the knx component, or is that a copy/paste leftover in the description?
| @@ -4,6 +4,7 @@ | |||
| For more details about this platform, please refer to the documentation at | |||
| https://home-assistant.io/components/scene.velux/ | |||
| """ | |||
| import asyncio | |||
| from homeassistant.components.scene import Scene | |||
There was a problem hiding this comment.
Add a blank line between standard library and homeassistant imports.
| if DATA_VELUX not in hass.data \ | ||
| or not hass.data[DATA_VELUX].initialized: | ||
| return False | ||
|
|
||
| entities = [] | ||
| for scene in hass.data[DATA_VELUX].pyvlx.scenes: | ||
| entities.append(VeluxScene(hass, scene)) |
| @@ -13,10 +14,6 @@ | |||
|
|
|||
| def setup_platform(hass, config, add_devices, discovery_info=None): | |||
There was a problem hiding this comment.
If this doesn't do any I/O, you can change this to the async version.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Code cleanup
def is_ondoes not exist within sceneshould_pollis already Falseasync_activateDATA_VELUXalways present inhass.dataif base component was set up correctly.