Use default voice id as fallback in get_tts_audio #123624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
bugfix
cla-signed
has-tests
integration: elevenlabs
small-pr
Schevv
approved these changes
Aug 12, 2024
joostlek
reviewed
Aug 12, 2024
| @@ -100,7 +100,7 @@ async def async_get_tts_audio( | |||
| """Load tts audio file from the engine.""" | |||
| _LOGGER.debug("Getting TTS audio for %s", message) | |||
| _LOGGER.debug("Options: %s", options) | |||
| voice_id = options[ATTR_VOICE] | |||
| voice_id = options.get(ATTR_VOICE, self._default_voice_id) | |||
There was a problem hiding this comment.
Did we already always have voice set during setup?
There was a problem hiding this comment.
You mean default_voice_id? It is a string that is set in init, so before the Entity is passed to async_add_entities. I verified the test I added failed beforehand and works now and I can't manage to run into the #123597 issue with this branch
There was a problem hiding this comment.
I see. We're setting CONF_VOICE during setup, ATTR_VOICE is injected in the prepare_text_to_speech method of a PipelineRun, but only if the voice is set by the user. Since this isn't the case in the automation that raised the issue, we need the .get() here
joostlek
approved these changes
Sep 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
We fallback to default voice id if voice is not set in options dict passed to
get_tts_audio.Type of change
Additional information
Checklist
ruff format homeassistant tests)