Pollen.com: Entity Registry updates and cleanup #12361
Conversation
homeassistant
added
cla-signed
platform: sensor.pollen
small-pr
What does this mean? We don't duplicate entities with the registry. We only make sure that they get the same entity ID each time |
| datas[data_key], | ||
| params, | ||
| name, | ||
| icon | ||
| icon, | ||
| adler32(str(config[CONF_ZIP_CODE]).encode('utf-8')) |
There was a problem hiding this comment.
Why would you do this? Why not just pass the zip ?
There was a problem hiding this comment.
Fighting a cold and my brain was locked on what I did for AirVisual. Will simplify.
| @property | ||
| def unique_id(self): | ||
| """Return a unique, HASS-friendly identifier for this entity.""" | ||
| return '{0}_{1}'.format(self._entity_id, slugify(self._name)) |
There was a problem hiding this comment.
Names are configurable and thus not unique.
There was a problem hiding this comment.
"Name" is a misnomer here: those are defined within CONDITIONS (example: Allergy Index: Forecasted Average). The user cannot change them.
| """Initialize the sensor.""" | ||
| self._attrs = {} | ||
| self._icon = icon | ||
| self._name = name | ||
| self._data_params = data_params | ||
| self._state = None | ||
| self._unit = None | ||
| self._entity_id = entity_id |
There was a problem hiding this comment.
This is not an entity id. Do you mean unique id?
|
@balloob RE: my breaking change note, I was stating that this PR changes the unique ID for these sensors (thus creating the possibility that duplicates of each sensor – with different unique IDs – was possible). That said, in review, I didn't have unique IDs before, so perhaps it's a moot point. Let me know and I can remove the breaking change warning. |
|
If there were no unique IDs before, they were not added to the entity registry. |
ghost
added
Description:
Related issue (if applicable): N/A
Pull request in home-assistant.github.io with documentation (if applicable): N/A
Example entry for
configuration.yaml(if applicable):Checklist:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests pass