Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Unifi SSID filtering to list comprehension #12344

Merged
merged 1 commit into from
Feb 12, 2018
Merged

Change Unifi SSID filtering to list comprehension #12344

merged 1 commit into from
Feb 12, 2018

Conversation

mikeodr
Copy link
Contributor

@mikeodr mikeodr commented Feb 12, 2018

Description:

Per review #12281 Changed from filter to list comprehension.

Checklist:

  • The code change is tested and works locally.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

Changed from filter to list comprehension.
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! Can be merged when build passes.

@MartinHjelmare MartinHjelmare changed the title Change Unifi SSID filtering to list comprehension. Change Unifi SSID filtering to list comprehension Feb 12, 2018
@MartinHjelmare MartinHjelmare merged commit 52f57b7 into home-assistant:dev Feb 12, 2018
@mikeodr mikeodr deleted the unifi-list-comp branch February 12, 2018 19:15
@balloob balloob mentioned this pull request Feb 22, 2018
@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants