zha: Add unique_id to entities #12331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
integration: zha
small-pr
houndci-bot
reviewed
Feb 12, 2018
| @@ -240,6 +241,7 @@ def async_device_initialized(self, device, join): | |||
| 'in_clusters': {cluster.cluster_id: cluster}, | |||
| 'out_clusters': {}, | |||
| 'new_join': join, | |||
| 'unique_id': '%s-%s-%s' % (device.ieee, endpoint_id, cluster_id), | |||
There was a problem hiding this comment.
line too long (85 > 79 characters)
balloob
approved these changes
Feb 12, 2018
MartinHjelmare
requested changes
Feb 12, 2018
| @@ -214,6 +214,7 @@ def async_device_initialized(self, device, join): | |||
| 'in_clusters': {c.cluster_id: c for c in in_clusters}, | |||
| 'out_clusters': {c.cluster_id: c for c in out_clusters}, | |||
| 'new_join': join, | |||
| 'unique_id': '%s-%s' % (device.ieee, endpoint_id), | |||
There was a problem hiding this comment.
Please use new style string formatting.
There was a problem hiding this comment.
Ie:
'{}-{}'.format(arg1, arg2)| @@ -240,6 +241,8 @@ def async_device_initialized(self, device, join): | |||
| 'in_clusters': {cluster.cluster_id: cluster}, | |||
| 'out_clusters': {}, | |||
| 'new_join': join, | |||
| 'unique_id': '%s-%s-%s' % (device.ieee, endpoint_id, | |||
3 tasks
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue (if applicable): fixes #12215
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass