Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Alexa Step Speaker Volume #12314

Merged
merged 1 commit into from
Feb 11, 2018
Merged

Conversation

lucasweb78
Copy link
Contributor

@lucasweb78 lucasweb78 commented Feb 11, 2018

Description:

The Alexa.StepSpeaker Interface returns volumeSteps not volume in the payload.

Checklist:

  • The code change is tested and works locally.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@balloob balloob added this to the 0.63.1 milestone Feb 11, 2018
@balloob balloob merged commit 767d3c6 into home-assistant:dev Feb 11, 2018
balloob pushed a commit that referenced this pull request Feb 12, 2018
@balloob balloob mentioned this pull request Feb 12, 2018
@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants