Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect entity namespace for entity registry #12313

Merged
merged 2 commits into from
Feb 12, 2018
Merged

Respect entity namespace for entity registry #12313

merged 2 commits into from
Feb 12, 2018

Conversation

balloob
Copy link
Member

@balloob balloob commented Feb 11, 2018

Description:

Fix entity registry not taking entity namespace into consideration when generating initial entity id.

Related issue (if applicable): fixes #

Example entry for configuration.yaml (if applicable):

light:
  platform: something
  entity_namespace: bla

Checklist:

  • The code change is tested and works locally.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@balloob balloob added this to the 0.63.1 milestone Feb 11, 2018
@balloob balloob requested a review from a team as a code owner February 11, 2018 18:31
@balloob balloob merged commit eb7adc7 into dev Feb 12, 2018
@balloob balloob deleted the registry-namespace branch February 12, 2018 04:55
balloob added a commit that referenced this pull request Feb 12, 2018
* Respect entity namespace for entity registry

* Lint
@balloob balloob mentioned this pull request Feb 12, 2018
balloob added a commit that referenced this pull request Feb 12, 2018
* Respect entity namespace for entity registry

* Lint
@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants