Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify Tahoma errors #12307

Merged
merged 1 commit into from
Feb 11, 2018
Merged

Clarify Tahoma errors #12307

merged 1 commit into from
Feb 11, 2018

Conversation

thijsdejong
Copy link
Contributor

@thijsdejong thijsdejong commented Feb 11, 2018 •
edited
Loading

Description:

This commit makes it a little more clear in the frontend as to what the error is.

Checklist:

  • The code change is tested and works locally.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass

fabaff
fabaff approved these changes Feb 11, 2018
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff merged commit 47bfef9 into home-assistant:dev Feb 11, 2018
@balloob balloob mentioned this pull request Feb 22, 2018
Merged
@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fabaff fabaff fabaff approved these changes

Assignees
No one assigned
Labels
cla-signed integration: tahoma small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thijsdejong @fabaff @homeassistant @bakedraccoon