Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_config script fix exit code #12291

Merged
merged 1 commit into from
Feb 11, 2018
Merged

Conversation

kellerza
Copy link
Member

Description:

Catch errors raised in bootstrap.py.

Related issue (if applicable): fixes #6200

Example entry for configuration.yaml (if applicable):

autmoation: !include bad.yaml

Checklist:

  • The code change is tested and works locally.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@homeassistant homeassistant added cla-signed core small-pr PRs with less than 30 lines. labels Feb 11, 2018
@balloob
Copy link
Member

balloob commented Feb 11, 2018

The check config tests are very flaky, breaking a lot of builds 😢 I just put up a PR to try to address it #12283

@balloob balloob merged commit 65c6f72 into home-assistant:dev Feb 11, 2018
@kellerza kellerza deleted the long-overdue branch February 11, 2018 18:34
@balloob balloob mentioned this pull request Feb 22, 2018
@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed core small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong exit code from check_config script
3 participants