Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated SABnzbd sensor to asyncio and switched to pypi library #12290

Merged
merged 2 commits into from
Feb 11, 2018

Conversation

jeradM
Copy link
Member

@jeradM jeradM commented Feb 11, 2018

Description:

Created asyncio version of SABnzbd API library and published to PyPI. Migrated sabnzbd sensor to use asyncio and new pypi library.

Checklist:

  • The code change is tested and works locally.

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

@balloob
Copy link
Member

balloob commented Feb 11, 2018

Ok to merge when tests pass.

@andrey-git
Copy link
Contributor

************* Module homeassistant.components.sensor.sabnzbd
E: 58, 4: Unable to import 'pysabnzbd.sabnzbd_api' (import-error)
E:130, 4: Unable to import 'pysabnzbd.sabnzbd_api' (import-error)
E:192, 8: Unable to import 'pysabnzbd.sabnzbd_api' (import-error)

@jeradM
Copy link
Member Author

jeradM commented Feb 11, 2018

Sorry guys, I'm not sure why I'm getting those errors. The package is on PyPI and everything is working locally. Am I missing something somewhere?

@andrey-git
Copy link
Contributor

You have _init_.py file. Is it on purpose?

@andrey-git
Copy link
Contributor

I think _init_.py does nothing. Python works fine without it, but pylint fails to parse the package. You can fix it by renaming the file to __init__.py

@jeradM
Copy link
Member Author

jeradM commented Feb 11, 2018

@andrey-git thank you for finding this. Man, what a bonehead mistake. I went ahead and just moved the classes into __init__.py for now to make the imports a little more concise.

@jeradM
Copy link
Member Author

jeradM commented Feb 11, 2018

Build log now showing

ERROR:homeassistant.bootstrap:Error loading /home/travis/build/home-assistant/home-assistant/tests/testing_config/component.yaml: Config file not found: None
check_config.py            237 ERROR    Error loading /home/travis/build/home-assistant/home-assistant/tests/testing_config/component.yaml: Config file not found: None

and other similar errors. Is this #12283 related?

@balloob
Copy link
Member

balloob commented Feb 11, 2018

Yeah, it's super flaky 😢

@balloob balloob merged commit 6c358fa into home-assistant:dev Feb 11, 2018
@balloob balloob mentioned this pull request Feb 22, 2018
@jeradM jeradM deleted the sabnzbd-asyncio branch March 22, 2018 22:52
@home-assistant home-assistant locked and limited conversation to collaborators Jul 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants