-
-
Notifications
You must be signed in to change notification settings - Fork 32.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Matter lock state follow-up #121669
Matter lock state follow-up #121669
Conversation
Hey there @home-assistant/matter, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
@@ -99,7 +99,7 @@ async def async_lock(self, **kwargs: Any) -> None: | |||
# the lock should acknowledge the command with an attribute update | |||
# but bad things may happen, so guard against it with a timer. | |||
self._optimistic_timer = self.hass.loop.call_later( | |||
5, self._reset_optimistic_state | |||
30, self._reset_optimistic_state |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We never test that the callback runs after the time.
To make it easier to test this make the time a module level constant that can easily be patched.
Proposed change
Follow-up of #121665 (which had a broken test) and extend the timer delay
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: