Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block icloud3 custom integration from breaking the recorder #121658

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

frenck
Copy link
Member

@frenck frenck commented Jul 10, 2024

Proposed change

Block the current version of the icloud3 custom integration, as it breaks the Home Assistant recorder.

gcobb321/icloud3#349

As the issue isn't fixed, we don't know the upcoming fixed version, hence I've set it to the current version + patch.

The alternative, is to set None as the fixed version, but that downside of that is: When the issue is fixed upstream, it will still be blocked.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@frenck frenck requested a review from a team as a code owner July 10, 2024 07:25
@home-assistant home-assistant bot added bugfix cla-signed core small-pr PRs with less than 30 lines. labels Jul 10, 2024
@frenck frenck added this to the 2024.7.2 milestone Jul 10, 2024
@gcobb321
Copy link

gcobb321 commented Jul 10, 2024

FYI-I have been in Switzerland since HA 2024.7 was released and will address this issue with an iCloud3 update when I return home next week. Unfortunately, the HA Mobile App SSL certificate expired while I was away and there is no way to update it that I am aware of without local access. That is blocking me from logging into my HA server via the Mobile App/Nabu Casa external link.

Edit: GitHub code has been updated to prevent iCloud3 from accessing recorder.py. Special update instructions are being sent to users with problems. This will be rolled into the iCloud3 code next week and released as v3.0.5.5.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants