-
-
Notifications
You must be signed in to change notification settings - Fork 32.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Direct Users to App-Specific Passwords for iCloud integration to prevent MFA spam #120945
Conversation
iCloud integration deauths often if not using App Specific Passwords. This spams MFA prompts on all devices and is not a good UX. Swap working to get people to use App Specific Passwords. HA Docs (https://www.home-assistant.io/integrations/icloud/) still need to be updated to reflect this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hey there @Quentame, @nzapponi, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Marked documentation as updated as I have created a PR in the docs repo |
Signed CLA |
PS: can you adjust the PR title to describe the change instead of referencing an issue? Thanks 👍 |
Done |
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@rcmaehl If this PR is ready, please don't forget to hit the "Ready for review" button to get it out of draft. ../Frenck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @rcmaehl 👍
../Frenck
iCloud integration deauths often if not using App Specific Passwords. This spams MFA prompts on all devices and is not a good UX. Swap wording to get people to use App Specific Passwords. HA Docs (https://www.home-assistant.io/integrations/icloud/) still need to be updated to reflect this
Breaking change
Proposed change
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: