Revert "Allow MQTT device based auto discovery" #118746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 585892f.
|
Hey there @emontnemery, @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
emontnemery
approved these changes
Jun 3, 2024
bdraco
approved these changes
Jun 3, 2024
bdraco
reviewed
Jun 3, 2024
| @@ -91,13 +82,6 @@ def async_log_discovery_origin_info( | |||
| message: str, discovery_payload: MQTTDiscoveryPayload, level: int = logging.INFO | |||
| ) -> None: | |||
| """Log information about the discovery and origin.""" | |||
| # We only log origin info once per device discovery | |||
| if not _LOGGER.isEnabledFor(level): | |||
There was a problem hiding this comment.
We should remerge this in a separate pr
|
|
||
|
|
||
| @callback | ||
| def _replace_all_abbreviations(discovery_payload: Any | dict[str, Any]) -> None: |
There was a problem hiding this comment.
There are some good improvements here that we could split into another PR as well while this is being reworked
|
#118757 is the rework |
frenck
pushed a commit
that referenced
this pull request
Jun 4, 2024
dgomes
pushed a commit
to dgomes/home-assistant
that referenced
this pull request
Jun 4, 2024
Revert "Allow MQTT device based auto discovery (home-assistant#109030)" This reverts commit 585892f.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #109030 which introduced a new schema for MQTT discovery
The main benefit of the new schema is that discovery of many (1800+) MQTT entities is more reliable, simply thanks to the reduction of discovery messages by roughly a factor of 10.
However, there were some unresolved questions: