Bump pydaikin to 2.13.1

[kingy444]

Breaking change

While not introducing new features the upstream has resolved the creation of items that are not needed. So entities that were previously created and not functional are now disabled

Proposed change

Dependancy bump to new version of pydaikin
fredrike/pydaikin@v2.11.1...v2.13.1

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes Update of sensor is taking over 10 seconds #115582 fixes Daikin integration fills logs with 'took longer than the scheduled update interval' #82972
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Ruff (ruff format homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @fredrike, mind taking a look at this pull request as it has been labeled with an integration (daikin) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of daikin can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign daikin Removes the current integration label and assignees on the pull request, add the integration domain after the command.
• @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
• @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

[kingy444]

@bdraco only tagging you as you were involved in issues #114345 and fredrike/pydaikin#3

I believe the dependancy bump should also fix these - but seeking clarification before tagging that as the case

[frenck]

Hi there @kingy444 👋

The tests seem to fail, could you take a look and make sure our CI passes?

Thanks! 👍

../Frenck

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

[kingy444]

Hi there @kingy444 👋

The tests seem to fail, could you take a look and make sure our CI passes?

Thanks! 👍

../Frenck

Hi @frenck is there an issue with the latest dev build? My Tests were passing so Ive blown my dockers away and restarted from scratch assuming i had a local issue (per https://developers.home-assistant.io/docs/development_environment/)

Given its all been blown away and started from scratch im a bit stumped where to go next. Ive done this numerous times now and its all the same, deleted the docker volumes, images everything.

Now even after running "Install all requirements" and "Install all test requirements" I am getting the below. If i pip install that, it moves to the next missing dependancy

I thought "Maybe they just arent in the requirements file" so tried to run gen_requirements_all and get the below

EDIT:
Just found i am getting this on the First line of every file too - figured it might be related

Error from running "pytest" from the Tasks list (instead of the command line)

[fredrike]

@kingy444 you need to apply this patch to allow tests to succeed:

diff --git a/tests/components/daikin/test_config_flow.py b/tests/components/daikin/test_config_flow.py
index 6d957384d4..8f32947b6a 100644
--- a/tests/components/daikin/test_config_flow.py
+++ b/tests/components/daikin/test_config_flow.py
@@ -28,9 +28,9 @@ def mock_daikin():
         """Mock the init function in pydaikin."""
         return Appliance
 
-    with patch("homeassistant.components.daikin.config_flow.Appliance") as Appliance:
+    with patch("homeassistant.components.daikin.config_flow.DaikinFactory") as Appliance:
         type(Appliance).mac = PropertyMock(return_value="AABBCCDDEEFF")
-        Appliance.factory.side_effect = mock_daikin_factory
+        Appliance.side_effect = mock_daikin_factory
         yield Appliance
 
 
@@ -90,7 +90,7 @@ async def test_abort_if_already_setup(hass: HomeAssistant, mock_daikin) -> None:
 )
 async def test_device_abort(hass: HomeAssistant, mock_daikin, s_effect, reason) -> None:
     """Test device abort."""
-    mock_daikin.factory.side_effect = s_effect
+    mock_daikin.side_effect = s_effect
 
     result = await hass.config_entries.flow.async_init(
         "daikin",

[kingy444]

thanks - just got to get my home assistant dev working again - there are some people on the discord with the same issues

[cremor]

pydaikin 2.13.0 has been released, could you update your PR to use that?

[kingy444]

pydaikin 2.13.0 has been released, could you update your PR to use that?

Definitely will, and will fix the tests etc too - but the above tagged issue was raised because vscode deployment appears to be broken at the moment making it hard to actually do anything on the Pr

Seems since moving to uv as I can revert that pr and the environment works...
Haven't heard anything back on that for a couple days.

ci is now passing

[bdraco]

It looks like there are some nice fixes.

• Are there any breaking changes expected?
• Should we tag this for 2024.6.3?

[kingy444]

It looks like there are some nice fixes.

• Are there any breaking changes expected?
• Should we tag this for 2024.6.3?

the only "breaking change" is noted in the description (with screenshots)

The integration previously created entities for all air con zones, even if disabled on the unit (so they never functioned) - These entities will no longer be created and need to be deleted manually (wouldnt know where to start to automate that)

Re the release - I'm good with what works for the team, this one seems pretty minor in terms of impact

[mover85]

fredrike/pydaikin#10

[kingy444]

hold off on merging - ive been able to replicate - was not something i changed so not something i tested.

Need to work out what changed in the parsing between the move from bitbucket to github

fredrike/pydaikin#10

[fredrike]

New version of pydaikin is published on pypi (fredrike/pydaikin@v2.11.1...v2.13.1)

[frenck]

Friendly nudge to @kingy444 cause of the message above.

[frenck]

Nice, thanks, @kingy444 👍

../Frenck