-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve syncing light states to deCONZ groups #117588
Improve syncing light states to deCONZ groups #117588
Conversation
group: Group, lights: list[Light], override: bool = False | ||
) -> None: | ||
"""Sync group color state with light.""" | ||
data = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't this mean that last brightness, last CT etc wins ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that is true, but that hasn't changed from before (except it was part of the library) behaviour hasn't changed, the real change here is group.raw["action"] = cast(TypedGroupAction, data)
where all data from all lights have been considered and then overriding any existing data in the group.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Kane610 👍
../Frenck
Breaking change
Proposed change
Change to take all lights states into consideration and only populate the available states.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: