-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump whirlpool-sixth-sense to 0.18.8 #115393
Bump whirlpool-sixth-sense to 0.18.8 #115393
Conversation
Hey there @abmantis, @mkmer, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Thanks @NodeJSmith for submitting this, the library diff looks ok to me and the change within HA looks good too. I noticed in the new version of the library that the moved header will now not be present in most other API calls. I don't have any way of testing this though. Have you verified that all existing functionality still works after making this change to the library? |
Tested here on Whirlpool appliances and still works for me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Breaking change
Proposed change
Bumps whirlpool-sixth-sense to 0.18.8. This update adjusts which calls use the
WP-CLIENT-BRAND
header. diffType of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: