Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024.4.1 #114934

Merged
merged 25 commits into from
Apr 5, 2024
Merged

2024.4.1 #114934

merged 25 commits into from
Apr 5, 2024

Conversation

frenck
Copy link
Member

@frenck frenck commented Apr 5, 2024

Release notes: home-assistant/home-assistant.io#32172

Noltari and others added 23 commits April 5, 2024 10:06
Fix brightness values in light.py

Bugfix to set the brightness to 0-100 which is what Lutron expects.
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
* Avoid blocking IO in downloader initialization

* Avoid blocking IO in downloader initialization
Co-authored-by: TheJulianJES <TheJulianJES@users.noreply.github.com>
* Create right import issues in Downloader

* Create right import issues in Downloader

* Create right import issues in Downloader

* Create right import issues in Downloader

* Fix

* Fix

* Fix

* Fix

* Apply suggestions from code review

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

* Fix

---------

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@home-assistant home-assistant bot added cla-signed core has-tests merging-to-master This PR is merging into the RC branch and should probably change the branch to `dev`. labels Apr 5, 2024
@frenck
Copy link
Member Author

frenck commented Apr 5, 2024

I'm not fully understanding why the tests are failing.

_____ ERROR collecting tests/components/system_bridge/test_config_flow.py ______
ImportError while importing test module '/home/runner/work/core/core/tests/components/system_bridge/test_config_flow.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/opt/hostedtoolcache/Python/3.12.2/x64/lib/python3.12/importlib/__init__.py:90: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/components/system_bridge/__init__.py:9: in <module>
    from systembridgemodels.const import MODEL_SYSTEM
E   ImportError: cannot import name 'MODEL_SYSTEM' from 'systembridgemodels.const' (/home/runner/work/core/core/venv/lib/python3.12/site-packages/systembridgemodels/const.py)

Locally the pass, and I do see MODE_SYSTEM locally as well.

@frenck
Copy link
Member Author

frenck commented Apr 5, 2024

Aah probably related: timmo001/system-bridge-connector@a016acc

@frenck
Copy link
Member Author

frenck commented Apr 5, 2024

Yup: #114842

Need to pull that one in.

@frenck frenck marked this pull request as ready for review April 5, 2024 13:33
@frenck frenck requested review from a team, bachya, Kane610 and bdraco as code owners April 5, 2024 13:33
@frenck frenck merged commit b1fb77c into master Apr 5, 2024
74 checks passed
@hrzlgnm
Copy link

hrzlgnm commented Apr 5, 2024

Hmm, any reason #114832 was not included as proposed by related closed issues?

@joostlek
Copy link
Member

joostlek commented Apr 5, 2024

Whoops, I forgot to tag it to the milestone

@github-actions github-actions bot locked and limited conversation to collaborators Apr 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed core has-tests merging-to-master This PR is merging into the RC branch and should probably change the branch to `dev`.
Projects
None yet
Development

Successfully merging this pull request may close these issues.