Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make hass-nabucasa a core requirement #112623

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Conversation

emontnemery
Copy link
Contributor

@emontnemery emontnemery commented Mar 7, 2024

Proposed change

Make hass-nabucasa a core requirement to ensure the correct version is installed

Background:

We import hass-nabucasa directly from the http integration as well as from the network helper:

from hass_nabucasa import remote # pylint: disable=import-outside-toplevel

from hass_nabucasa import ( # pylint: disable=import-outside-toplevel
remote,
)

If either of these imports happen before we've processed the requirements of the cloud integration, hass_nabucasa is already imported before we upgrade it with help of pip, which causes the import errors seen in the linked PR.

An alternative solution would be to remove the imports of hass-nabucasa from the network helper and the http integration

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@emontnemery emontnemery requested a review from a team as a code owner March 7, 2024 15:38
@home-assistant home-assistant bot added cla-signed small-pr PRs with less than 30 lines. labels Mar 7, 2024
@emontnemery
Copy link
Contributor Author

Should we remove hass-nabucasa as a requirement of the cloud integration since it's now a core requirement?

@balloob
Copy link
Member

balloob commented Mar 7, 2024

Let's keep it in cloud, so we know what drives the requirement.

@balloob balloob added this to the 2024.3.1 milestone Mar 7, 2024
@balloob
Copy link
Member

balloob commented Mar 7, 2024

Tagging it for the milestone

@emontnemery emontnemery merged commit 177d8f3 into dev Mar 7, 2024
49 checks passed
@emontnemery emontnemery deleted the hass_nabucasa_core_req branch March 7, 2024 16:11
@github-actions github-actions bot locked and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cherry-picked cla-signed small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple issues related to RemoteActivationNotAllowed
4 participants