Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sensors to Weatherflow Cloud #111651

Merged
merged 38 commits into from
Jul 19, 2024
Merged

Conversation

jeeftor
Copy link
Contributor

@jeeftor jeeftor commented Feb 27, 2024

Proposed change

  • Bump backing lib
  • Adding in temperature sensors
  • Add Wind Sensors
  • Add Air/Pressure Sensors
  • Changing query rate to 5 seconds - based on REST Api limits

Our REST rate limits are not connected to our web socket rate limits. For REST you can make 100 requests per minute. There is some burst capacity built into the system, but the general rule of thumb it to keep the number of REST requests per user to under 100 per minute.

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@MartinHjelmare
Copy link
Member

Your branch is tainted with unrelated already merged commits.

@jeeftor jeeftor force-pushed the weatherflow_sensors branch 3 times, most recently from 032d879 to 59fcaf2 Compare March 15, 2024 23:07
@jeeftor
Copy link
Contributor Author

jeeftor commented Mar 18, 2024

Your branch is tainted with unrelated already merged commits.

Everything should be fixed now -> did a clean rebase and a force push

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jul 19, 2024
@joostlek joostlek merged commit de18be2 into home-assistant:dev Jul 19, 2024
26 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2024
entry.entry_id
]

stations = coordinator.data.keys()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to access dict.keys() to iterate over just the keys in a dict. Just do:

for key in some_dict:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I could rewrite like this:

    async_add_entities(
        WeatherFlowCloudSensor(coordinator, sensor_description, station_id)
        for station_id in coordinator.data
        for sensor_description in WF_SENSORS
    )

instead of:

    stations = coordinator.data.keys()

    async_add_entities(
        WeatherFlowCloudSensor(coordinator, sensor_description, station_id)
        for station_id in stations
        for sensor_description in WF_SENSORS
    )

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

@home-assistant home-assistant unlocked this conversation Aug 25, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants