-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tibber: Add attribute to current price with available hourly prices #111164
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hey there @Danielhiversen, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
060eeb2
to
c614068
Compare
Thanks for your contribution This has been suggested and not approved before, #69364 |
probably the only way to get this in, is to build an |
Ah, sweet. I reached out in the discussion linked in the other PR to see what the suggested approach for something like this would be.
It indeed sounded like something like this would be the way to go 👍🏻 |
I'm closing this PR here, please open a new PR if you intend to implement the service call with a response. Thanks 👍 |
Proposed change
This PR adds an attribute to the current price with the available hourly prices, in a similar way as the nordpool integration lists it.
I came across the need to graph energy prices and started out using the nordpool integration to get them. However Tibber adds some minor costs on top of the nordpool price that are not necessarily constant, thus I had a need to get prices directly from the Tibber API.
When I put this in place for my own usage, I found that the underlying
pyTibber
has a function that populates a bunch of these attributes. Thus an option to merging this PR would be to put it in place directly inpyTibber
, however that would impact more than HA. I believe the maintainer of both this integration andpyTibber
is the same person, so perhaps the discussion can be had in this PR on what would be preferred.Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: