Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tibber: Add attribute to current price with available hourly prices #111164

Closed

Conversation

Berglund
Copy link

Proposed change

This PR adds an attribute to the current price with the available hourly prices, in a similar way as the nordpool integration lists it.

I came across the need to graph energy prices and started out using the nordpool integration to get them. However Tibber adds some minor costs on top of the nordpool price that are not necessarily constant, thus I had a need to get prices directly from the Tibber API.

When I put this in place for my own usage, I found that the underlying pyTibber has a function that populates a bunch of these attributes. Thus an option to merging this PR would be to put it in place directly in pyTibber, however that would impact more than HA. I believe the maintainer of both this integration and pyTibber is the same person, so perhaps the discussion can be had in this PR on what would be preferred.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Berglund

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft February 22, 2024 21:21
@home-assistant
Copy link

Hey there @Danielhiversen, mind taking a look at this pull request as it has been labeled with an integration (tibber) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tibber can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign tibber Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@Berglund Berglund marked this pull request as ready for review February 22, 2024 21:23
@Berglund Berglund marked this pull request as draft February 22, 2024 21:33
@Berglund Berglund marked this pull request as ready for review February 22, 2024 21:34
@Berglund Berglund force-pushed the hourly-prices-attribute branch from 060eeb2 to c614068 Compare February 22, 2024 22:10
@Danielhiversen
Copy link
Member

Thanks for your contribution

This has been suggested and not approved before, #69364

@zweckj
Copy link
Member

zweckj commented Feb 23, 2024

probably the only way to get this in, is to build an entity service for it, which returns the forecast (like weather does it from 2023.3.0)

@Berglund
Copy link
Author

Thanks for your contribution

This has been suggested and not approved before, #69364

Ah, sweet. I reached out in the discussion linked in the other PR to see what the suggested approach for something like this would be.

probably the only way to get this in, is to build an entity service for it, which returns the forecast (like weather does it from 2023.3.0)

It indeed sounded like something like this would be the way to go 👍🏻

@gjohansson-ST
Copy link
Member

I'm closing this PR here, please open a new PR if you intend to implement the service call with a response. Thanks 👍

@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants