fix construct==2.8.17 Cause the plug-in failure #11089
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix construct==2.8.17 Cause the plug-in failure
houndci-bot
reviewed
Dec 11, 2017
| @@ -31,7 +31,7 @@ | |||
| vol.Optional(CONF_NAME, default=DEFAULT_NAME): cv.string, | |||
| }) | |||
|
|
|||
| REQUIREMENTS = ['python-miio==0.3.2'] | |||
| REQUIREMENTS = ['python-miio==0.3.2','construct==2.8.16'] | |||
Update requirements_all.txt
|
This is not going to be fixed by pinning the version on upstream; if pinning for the specific version in homeassistant is fine, then feel free to do that. I would prefer to have a clean solution (either by fixing python-miio to work with the new construct version, or by fixing construct if the problem lies there). |
|
I just tested the newer version out, and made mirobo to print out the version number. Seems to work fine here. |
|
It doesn't matter, I just provide a way to the fastest possible repair, because time is limited, can't further wrong, just as a reminder, after all, a lot of people already can't use, thank you for your effort |
ghost
added
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix construct==2.8.17 Cause the plug-in failure
Description:
Related issue : fixes #11048 (comment)
At the same time update in python-miio
rytilahti/python-miio#140
See which side to submit first
See which side first submitted to solve the problem