Add GPS coords to meraki #10998
Merged
Add GPS coords to meraki #10998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @addelovein, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
houndci-bot
reviewed
Dec 6, 2017
| if lat=="NaN" or lng=="NaN": | ||
| _LOGGER.debug("No coordinates received, skipping gps_location for: " + mac) | ||
| gps_location=None | ||
| accuracy=None |
|
|
||
| if lat=="NaN" or lng=="NaN": | ||
| _LOGGER.debug("No coordinates received, skipping gps_location for: " + mac) | ||
| gps_location=None |
| mac = i["clientMac"] | ||
| _LOGGER.debug("clientMac: %s", mac) | ||
|
|
||
| if lat=="NaN" or lng=="NaN": | ||
| _LOGGER.debug("No coordinates received, skipping gps_location for: " + mac) |
| mac = i["clientMac"] | ||
| _LOGGER.debug("clientMac: %s", mac) | ||
|
|
||
| if lat=="NaN" or lng=="NaN": |
| mac = i["clientMac"] | ||
| _LOGGER.debug("clientMac: %s", mac) | ||
|
|
houndci-bot
reviewed
Dec 6, 2017
|
|
||
| if lat == "NaN" or lng == "NaN": | ||
| _LOGGER.debug( | ||
| "No coordinates received, skipping gps_location for: " + mac |
balloob
approved these changes
Dec 10, 2017
akatrevorjay
added a commit
to akatrevorjay/home-assistant
that referenced
this pull request
Dec 11, 2017
…ent-being-nonexistent * origin/dev: Volvo on call: Optional use of Scandinavian miles. Also add average fuel consumption property (home-assistant#11051) add custom bypass status to total connect (home-assistant#11042) Refactor hue to split bridge support from light platform (home-assistant#10691) Add GPS coords to meraki (home-assistant#10998) Add a caldav calendar component (home-assistant#10842) Added support for cover in tellstick (home-assistant#10858)
akatrevorjay
added a commit
to akatrevorjay/home-assistant
that referenced
this pull request
Dec 11, 2017
…into dev * 'dev' of https://github.com/home-assistant/home-assistant: Volvo on call: Optional use of Scandinavian miles. Also add average fuel consumption property (home-assistant#11051) add custom bypass status to total connect (home-assistant#11042) Refactor hue to split bridge support from light platform (home-assistant#10691) Add GPS coords to meraki (home-assistant#10998) Add a caldav calendar component (home-assistant#10842) Added support for cover in tellstick (home-assistant#10858)
Merged
ghost
added
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added support for GPS coordinates for Meraki. BLE devices will contain NaN and therefor be ignored.
Checklist:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests pass