Add Outside temperature and humidity for ecobee sensor

[PhracturedBlue]

Description:

Reads current outside humidity and temperature from Ecobee. This is useful for knowing what the Ecobee thinks the external temperature is.

Checklist:

If the code communicates with devices, web services, or third-party tools:

• Local tests with tox run successfully. Your PR cannot be merged unless tests pass
• New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
• New dependencies are only imported inside functions that use them ([example][ex-import]).
• New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

[tinloaf]

This would add "weather" data to a "climate" device. The climate component is not made to handle weather data, I think. For that, there is the "weather" component. If you really want weather data from ecobee, I think it would be better to implement an ecobee platform for the weather component.

[PhracturedBlue]

While having a weather component could be useful and I may implement it, I don't see why his doesn't also look like other sensor data from the ecobee. Personally I don't trust the ecobee weather data (and see no reason why it would be superior to the existing Web based weather components), and the whole reason for wanting a temperature sensor is to verify it against an actual sensor so that i can compensate my heat-pump.

[pvizeli]

I think also that should be into weather component. The sonsor is okay for sensor endpoints. That data are from a webapi and have more data they can be used as weather. But I'm not sure what will be the best for things like this. @balloob @fabaff any inputs ?

[PhracturedBlue]

As an alternative, what about adding this one parameter (outside temperature) to the climate component? While the ecobee does provide weather data, I believe current outside temperature is the only attribute used by the ecobee in its decision making process (whether to use a heat-pump or aux heat). Thus a case could be made to store it along with the climate data. My main issue with creating a weather component is that I don't see it providing any value vs any of the existing web based weather components with the exception of this single parameter. And it seems like it just adds a lot of code and potential maintenance for a small ROI vs he other options.

[arsaboo]

My 2 cents. I don't think we should change it to a weather component as that is the not the purpose of a thermostat. Moreover, the internal weather information is not entirely reliable or complete to be used as a weather component.

[pvizeli]

https://www.ecobee.com/home/developer/api/documentation/v1/objects/WeatherForecast.shtml

I see no problem to make a weather platform too. Please do that and remove that from sensor. You can discovery that like sensor. This implementation look like a workaround while you give only limited access to all data and only last forecast.

The humity is okay.

[PhracturedBlue]

Replacing this pull request with:
#10869

[pvizeli]

You can still add humity, that was not the point of the problem :)

[PhracturedBlue]

the humidity is part of the weather component now, why store it twice? The only piece of info I cared about was temperature. Since it is available in the weather component, I can use it from there.

[pvizeli]

You are right, sorry