-
-
Notifications
You must be signed in to change notification settings - Fork 32k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Climate component: add supported_features #10658
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
28bc61b
Implement supported_features for the climate component
tinloaf e23de77
Test supported features
tinloaf 93b4caa
Convert generic thermostat to supported features
tinloaf fb287bf
Max / min temperature are not features
tinloaf 110345d
Fix lint
tinloaf ea660a6
Min / max humidity are not features
tinloaf 3f6ff08
Linting
tinloaf 3b19f58
Remove current temperature / humidity
tinloaf 645af01
Move c-hacker-style constants to boring integers. Booo!
tinloaf 1c34cfb
Refactor all the climate platforms to use the new supported_features
tinloaf ff5b471
Force all climate platforms to implement supported_features
tinloaf a62146c
Fix mistakes
tinloaf 3401cf5
Adapt hive platform
tinloaf f3cf9ea
Move flags into a constant
tinloaf 6d9942b
Calm the hound
tinloaf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these changes to ecobee included in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because ecobee could so far only set
target_temperature_high
andtarget_temperature_low
at the same time. I figured that ifSUPPORT_TARGET_TEMPERATURE_HIGH
andSUPPORT_TARGET_TEMPERATURE_LOW
are two different flags, then it must be possible to set only one of them.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will the high/low target temps still be visible in the frontend graph without those supported features?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly: I can't figure out how this would currently be shown in the front end. There is code computing whether it should be shown or not in line
https://github.com/tinloaf/home-assistant-polymer/blob/8201dd34761dbb8feb219e9c9c3cb58e841dd412/src/more-infos/more-info-climate.html#L272
(still based on the old attribute-based detection), but that is never used. The actual temperature controls in
https://github.com/tinloaf/home-assistant-polymer/blob/8201dd34761dbb8feb219e9c9c3cb58e841dd412/src/more-infos/more-info-climate.html#L95-L108
also don't use it. The included
ha-climate-control
also doesn't seem to support it.In short: I did not change anything regarding low / high temperatures, I just added the support flag. It does not seem that the front end currently supports setting these values. It would be a next step to implement that in the front end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We used to have a slider with 2 handles to set low and high temp. It got removed in favor of the big buttons and then we lost that functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which functionality is lost?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is currently no way of setting
target_temperature_high
ortarget_temperature_low
via the front end. You can of course still set it via service calls.