Alexa improvements #10632

robbiet480 · 2017-11-17T09:38:58Z

Description:

This is me trying to match the major functionality of Haaska and because @maddox begged and pleaded for me to do so 😝

Adds support for the following domains:
- alert
- automation
- cover
- fan
  - supports on/off and set speed
- group
- lock
  - lock and unlock, but unlock is untested as Amazon has disabled unlock for now
- media_player
  - play
  - pause
  - stop
  - set volume
  - adjust volume
  - next track
  - previous track
- scene
Adds customize attributes
- Props to customize display/invocation
  - alexa_hidden - hide from Alexa
  - alexa_name - change name displayed/used by Alexa
  - alexa_description - change description shown in Alexa
- Props to control displayCategories
  - alexa_display_categories - set displayCategories, useful for things like media_player (TV/SPEAKERS) or scene (ACTIVITY_TRIGGER/SCENE_TRIGGER)
Change description to entity ID instead of empty string so it looks better in Alexa app
Change manufacturer name from Unknown to Home Assiatant as per discovery recommendations and so it looks better in Alexa app
Minor grammar/readability fixes

Checklist:

If the code does not interact with devices:

Local tests with tox run successfully. Your PR cannot be merged unless tests pass
Tests have been added to verify that the new code works.

…n app

postlund · 2017-11-17T09:45:29Z

This is awesome! 👍

robbiet480 · 2017-11-17T09:47:43Z

@balloob (calling you out since I believe you own the skill) you should be aware of special requirements for SceneController, specifically that only certain devices are allowed to be controlled via scenes. I'm unsure if logic should be added to ensure that blacklisted devices can't run, let me know what you want to do...

… be used on any entity

robbiet480 · 2017-11-17T11:42:01Z

Also we need a way to blacklist or whitelist entire domains just like Haaska. Unsure how best to do this since cloud is bringing up alexa.smart_home. Configuration under cloud seems a bit weird...

maddox · 2017-11-17T15:50:37Z

🤗

maddox · 2017-11-17T15:51:58Z

I noticed last night that when asking alexa to run a Scene, it worked, but it returned an error. But having that Scene triggered via a Routine, it worked without Alexa mentioning an error. I'll try to get some logs next time.

balloob · 2017-11-17T17:00:51Z

Nice!

For filtering, let's use the entity filter helper. (In a future PR)

Configuration via the cloud.

cloud:
  alexa:
    filters:
      include_domains:
      include_entities:
      exclude_domains:
      exclude_entities:

This will make it easier for us in the future to make a UI for it 👍

Update: I initially included that we shouldn't use customize but put that under cloud config instead, but realized that we lose context.

balloob · 2017-11-17T17:05:58Z

tests/components/alexa/test_smart_home.py

    hass.states.async_set(
        '{}.test'.format(domain), 'off', {
            'friendly_name': "Test {}".format(domain)
        })

-    call = async_mock_service(hass, domain, 'turn_on')
+    call = async_mock_service(hass, 'homeassistant', 'turn_on')


Any reason we would change this to homeassistant instead of directly calling the domain? Saves 1 service call -> faster.

Oh I guess it doesn't work for groups.

Fixed in this PR since time is of the essence for Alexa.

maddox · 2017-11-17T17:15:07Z

THIS IS A HUGE DEAL!!!!!!

Thanks everyone!

arsaboo · 2017-11-17T17:16:41Z

HUGE indeed....thanks a lot!

Redferne · 2017-11-18T03:05:21Z

Great work! We are still limited by Amazon by having us saying "Alexa, ask to...." and the manual dual configuration in both HA and ASK, right? This was/is the main reason for the great Haaska which is running great on the V2 api. Configure the lambda once and no need to ever touch it again.

jer78 · 2017-11-18T05:15:44Z

Very excited for this!! 😁

* Initial scene support * Initial fan support * ordering * Initial lock support * Scenes cant be deactivated; Correct the scene display category * Initial input_boolean support * Support customization of Alexa discovered entities * Initial media player support * Add input_boolean to tests * Add play/pause/stop/next/previous to media player * Add missing functions and pylint * Set manufacturerName to Home Assistant since the value is displayed in app * Add scene test * Add fan tests * Add lock test * Fix volume logic * Add volume tests * settup -> setup * Remove unused variable * Set required scene description as per docs * Allow setting scene category (ACTIVITY_TRIGGER/SCENE_TRIGGER) * Add alert, automation and group support/tests * Change display categories to match docs * simplify down the display category props into a single prop which can be used on any entity * Fix tests to expect proper display categories * Add cover support * sort things * Use generic homeassistant domain for turn on/off

nordicblue · 2017-11-24T23:30:57Z

Hey guys!

Got excited when the latest release of HA brought me to this page and I saw that there is fan support. I'm just a little confused as to how it functions?

In the API/pi/lights, it seems that my fan is still listed as a dimmable light, I'm assuming this is not for the emulated hue and requires me to setup the lambda API? Can someone please point me to what I need to configure in order to ask Alexa to set my fan speed?

Thanks a bunch!!

	"2": {
		"modelid": "HASS123",
		"name": "Fan",
		"state": {
			"bri": 85,
			"on": true,
			"reachable": true
		},
		"swversion": "123",
		"type": "Dimmable light",
		"uniqueid": "fan.bedroom_fan"
	},

robbiet480 added 19 commits November 16, 2017 19:36

Initial scene support

70a2a79

Initial fan support

647d547

ordering

3110511

Initial lock support

36df797

Scenes cant be deactivated; Correct the scene display category

c3c8ba2

Initial input_boolean support

000565c

Support customization of Alexa discovered entities

2ac6d55

Initial media player support

0482d28

Add input_boolean to tests

106bb1a

Add play/pause/stop/next/previous to media player

42cec8e

Add missing functions and pylint

ccd61ba

Set manufacturerName to Home Assistant since the value is displayed i…

506d27d

…n app

Add scene test

1de430c

Add fan tests

a53e2a1

Add lock test

1d53d93

Fix volume logic

c422911

Add volume tests

ecf058b

settup -> setup

86b5039

Remove unused variable

4094539

homeassistant added platform: alexa.smart_home cla-signed labels Nov 17, 2017

robbiet480 added 2 commits November 17, 2017 01:46

Set required scene description as per docs

d44729d

Allow setting scene category (ACTIVITY_TRIGGER/SCENE_TRIGGER)

f19724f

balloobbot added the platform label Nov 17, 2017

robbiet480 added 4 commits November 17, 2017 01:55

Add alert, automation and group support/tests

ea6deff

Change display categories to match docs

f3f3d78

simplify down the display category props into a single prop which can…

b012abf

… be used on any entity

Fix tests to expect proper display categories

c5befd2

homeassistant added the cla-signed label Nov 17, 2017

robbiet480 added 2 commits November 17, 2017 02:44

Add cover support

38c6d0e

sort things

6583049

Use generic homeassistant domain for turn on/off

fcba482

homeassistant added the cla-signed label Nov 17, 2017

balloob reviewed Nov 17, 2017

View reviewed changes

balloob approved these changes Nov 17, 2017

View reviewed changes

balloob added this to the 0.58 milestone Nov 17, 2017

balloob merged commit 2b60fca into home-assistant:dev Nov 17, 2017

robbiet480 mentioned this pull request Nov 18, 2017

Implement entity and domain exclude/include for Alexa #10647

Merged

2 tasks

balloobbot added the cherry-picked label Nov 18, 2017

balloob mentioned this pull request Nov 18, 2017

0.58 #10630

Merged

This was referenced Nov 19, 2017

WIP: Update customizing-devices.markdown home-assistant/home-assistant.io#4013

Closed

WIP: Update cloud.markdown home-assistant/home-assistant.io#4015

Merged

home-assistant locked and limited conversation to collaborators Nov 24, 2017

ghost added integration: smart_home and removed platform: alexa.smart_home labels Mar 21, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Alexa improvements #10632

Alexa improvements #10632

robbiet480 commented Nov 17, 2017 •

edited

Loading

postlund commented Nov 17, 2017

robbiet480 commented Nov 17, 2017

robbiet480 commented Nov 17, 2017

maddox commented Nov 17, 2017

maddox commented Nov 17, 2017

balloob commented Nov 17, 2017 •

edited

Loading

balloob Nov 17, 2017

balloob Nov 17, 2017

robbiet480 Nov 18, 2017

maddox commented Nov 17, 2017

arsaboo commented Nov 17, 2017

Redferne commented Nov 18, 2017

jer78 commented Nov 18, 2017

nordicblue commented Nov 24, 2017

Alexa improvements #10632

Alexa improvements #10632

Conversation

robbiet480 commented Nov 17, 2017 • edited Loading

Description:

Checklist:

postlund commented Nov 17, 2017

robbiet480 commented Nov 17, 2017

robbiet480 commented Nov 17, 2017

maddox commented Nov 17, 2017

maddox commented Nov 17, 2017

balloob commented Nov 17, 2017 • edited Loading

balloob Nov 17, 2017

Choose a reason for hiding this comment

balloob Nov 17, 2017

Choose a reason for hiding this comment

robbiet480 Nov 18, 2017

Choose a reason for hiding this comment

maddox commented Nov 17, 2017

arsaboo commented Nov 17, 2017

Redferne commented Nov 18, 2017

jer78 commented Nov 18, 2017

nordicblue commented Nov 24, 2017

robbiet480 commented Nov 17, 2017 •

edited

Loading

balloob commented Nov 17, 2017 •

edited

Loading