-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pip install --prefix='' workaround seems incompatible with pip >= 21.3 #74405
Comments
recorder documentation |
Hey there @home-assistant/core, mind taking a look at this issue as it has been labeled with an integration ( |
Note: Can also confirm that python-pip 21.0-1 did not manifest the error, but python-pip 22.1.2-1 does:
|
Hard for me to test different globally-installed pip versions, but some fairly suggestive output from testing with pip 21.1 in a virtualenv (21.0 doesn't report these):
and pip 21.3 outright fails:
https://peps.python.org/pep-0632/ seems relevant, as it's taking place as part of Python 3.10:
|
Looks like the previous workaround was implemented as part of #64068. Thank you so much for filing this issue, by the way! |
If anyone is attempting to build HA for Arch Linux, here's a Gist with the https://gist.github.com/synthead/819fa9bad91f9ba905125b2c7f34937d |
Note: using |
Confirmed that adding
Note that the config is in the correct location, as it does have effect on non-user installs when set to a non-default value:
Given Home Assistant already requires pip >= 21.0, going to submit a PR for removing the |
Remove --prefix workaround See discussion in #74405. This workaround is no longer needed on pip >= 21.0 and actively causes problems for pip >= 21.3.
Remove --prefix workaround See discussion in #74405. This workaround is no longer needed on pip >= 21.0 and actively causes problems for pip >= 21.3.
The problem
Seeing errors like the following when updating Home Assistant on Arch:
This looks like a manifestation of the behavior mentioned in this comment: https://stackoverflow.com/questions/4495120/combine-user-with-prefix-error-with-setup-py-install/4495175#comment32831892_4495175
Commenting out this line resolved the issue and allowed dependencies to be installed in deps as intended. Not clear what exactly in the environment is causing this interaction, but that "workaround" seems quite old at this point and it looks like
--prefix=
is being treated as "use/
as prefix" instead of "unset prefix" somehow.Note also that the SO question has been updated with a different argument to pip,
--install-option="--prefix="
, rather than--prefix=
as is done in package.py.What version of Home Assistant Core has the issue?
2022.6.7
What was the last working version of Home Assistant Core?
2022.4.6
What type of installation are you running?
Home Assistant Core
Integration causing the issue
recorder
Link to integration documentation on our website
https://www.home-assistant.io/integrations/recorder/
Diagnostics information
No response
Example YAML snippet
No response
Anything in the logs that might be useful for us?
No response
Additional information
OS: Arch Linux
Architecture: x86_64
Python version: core/python 3.10.5-1
Downstream bug report: https://bugs.archlinux.org/task/75204
Maybe with newer (setuptools-based) pip, the entire
PYTHONUSERBASE={target} --user --prefix=
runaround can just be replaced with--prefix={target}
?The text was updated successfully, but these errors were encountered: