Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aiohttp.server error in 2024.10.0b2 - Host 'homeassistant.local:8123' cannot contain ':' (at position 19) #126961

Closed
SeanPM5 opened this issue Sep 27, 2024 · 2 comments · Fixed by #126970
Milestone

Comments

@SeanPM5
Copy link
Contributor

SeanPM5 commented Sep 27, 2024

The problem

The yarl bump in #126872 has seemingly caused broken functionality in the Frigate Card, it's no longer loading any thumbnails for events/clips gallery or snapshots gallery after updating to 2024.10.0b2 and is printing hundreds of errors in the logs. (Have since upgraded to b3 as well, same issue).

Screen Shot 2024-09-27 at 3 01 50 PM

I can create an issue on their repo if it's something that should be addressed on their end. But it was working fine in b1 and broke in b2.

EDIT: It's not just the Frigate card, but Frigate snapshots in general. Push notifications to phone have broken image attachments too (500 forbidden error).

edit 2: left home and it works fine when on my external Nabu Casa URL, it's just the internal URL (homeassistant.local:8123) with issues.

Logger: aiohttp.server
Source: /usr/local/lib/python3.12/site-packages/aiohttp/web_protocol.py:448
First occurred: 3:15:56 PM (657 occurrences)
Last logged: 3:40:41 PM

Error handling request
Traceback (most recent call last):
  File "/usr/local/lib/python3.12/site-packages/aiohttp/web_protocol.py", line 477, in _handle_request
    resp = await request_handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/aiohttp/web_app.py", line 559, in _handle
    return await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/aiohttp/web_middlewares.py", line 117, in impl
    return await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/http/security_filter.py", line 92, in security_filter_middleware
    return await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/http/forwarded.py", line 83, in forwarded_middleware
    return await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/http/request_context.py", line 26, in request_context_middleware
    return await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/http/ban.py", line 85, in ban_middleware
    return await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/http/auth.py", line 242, in auth_middleware
    return await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/http/headers.py", line 32, in headers_middleware
    response = await handler(request)
               ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/http.py", line 73, in handle
    result = await handler(request, **request.match_info)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/frigate/views.py", line 154, in get
    return await self._handle_request(request, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/frigate/views.py", line 186, in _handle_request
    source_header = _init_header(request)
                    ^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/frigate/views.py", line 558, in _init_header
    forward_proto = request.url.scheme
                    ^^^^^^^^^^^
  File "aiohttp/_helpers.pyx", line 30, in aiohttp._helpers.reify.__get__
  File "/usr/local/lib/python3.12/site-packages/aiohttp/web_request.py", line 457, in url
    url = URL.build(scheme=self.scheme, host=self.host)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/yarl/_url.py", line 380, in build
    netloc = cls._make_netloc(
             ^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/yarl/_url.py", line 1052, in _make_netloc
    ret = cls._encode_host(host)
          ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/yarl/_url.py", line 1033, in _encode_host
    _host_validate(host)
  File "/usr/local/lib/python3.12/site-packages/yarl/_url.py", line 1602, in _host_validate
    raise ValueError(
ValueError: Host 'homeassistant.local:8123' cannot contain ':' (at position 19)

What version of Home Assistant Core has the issue?

2024.10.0b2

What was the last working version of Home Assistant Core?

2024.10.0b1

What type of installation are you running?

Home Assistant OS

Integration causing the issue

No response

Link to integration documentation on our website

No response

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

I have IPv6 disabled in network config if that matters

@mib1185 mib1185 added this to the 2024.10.0 milestone Sep 27, 2024
@bdraco
Copy link
Member

bdraco commented Sep 27, 2024

bdraco added a commit that referenced this issue Sep 27, 2024
@bdraco
Copy link
Member

bdraco commented Sep 27, 2024

https://www.dockerstatus.com/ still shows an active incident but it seems to be releasing now on attempt 3. Sadly each attempt takes about 70 minutes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants