Reolink fix not unregistering webhook during ReAuth (#117490)

home-assistant · May 17, 2024 · 615ae78 · 615ae78
1 parent b86513c
commit 615ae78
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/homeassistant/components/reolink/__init__.py b/homeassistant/components/reolink/__init__.py
@@ -85,6 +85,7 @@ async def async_device_config_update() -> None:
             try:
                 await host.update_states()
             except CredentialsInvalidError as err:
+                await host.stop()
                 raise ConfigEntryAuthFailed(err) from err
             except ReolinkError as err:
                 raise UpdateFailed(str(err)) from err

diff --git a/tests/components/reolink/test_init.py b/tests/components/reolink/test_init.py
@@ -5,7 +5,7 @@
 from unittest.mock import AsyncMock, MagicMock, Mock, patch
 
 import pytest
-from reolink_aio.exceptions import ReolinkError
+from reolink_aio.exceptions import CredentialsInvalidError, ReolinkError
 
 from homeassistant.components.reolink import FIRMWARE_UPDATE_INTERVAL, const
 from homeassistant.config import async_process_ha_core_config
@@ -50,6 +50,11 @@
             AsyncMock(side_effect=ReolinkError("Test error")),
             ConfigEntryState.SETUP_RETRY,
         ),
+        (
+            "get_states",
+            AsyncMock(side_effect=CredentialsInvalidError("Test error")),
+            ConfigEntryState.SETUP_ERROR,
+        ),
         (
             "supported",
             Mock(return_value=False),