Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification: "when_relative" for "chronometer" #1044

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

Roffild
Copy link
Contributor

@Roffild Roffild commented Mar 15, 2024

@jpelgrom
Copy link
Member

Can you add a beta label, to indicate this is not yet available? See any other documentation PR describing a new feature as an example.

@Roffild
Copy link
Contributor Author

Roffild commented Mar 15, 2024

Can you add a beta label, to indicate this is not yet available? See any other documentation PR describing a new feature as an example.

I do not have rights to add labels.

@dshokouhi
Copy link
Member

Can you add a beta label, to indicate this is not yet available? See any other documentation PR describing a new feature as an example.

I do not have rights to add labels.

thats not what was asked, please look at a previous PR to add a beta label like this one #1036

Copy link
Member

@dshokouhi dshokouhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a beta label next to the newly introduced parameter

@home-assistant home-assistant bot marked this pull request as draft March 19, 2024 00:32
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@Roffild
Copy link
Contributor Author

Roffild commented Mar 22, 2024

This is not beta. This is the final feature :)

@Roffild Roffild marked this pull request as ready for review March 22, 2024 10:10
@home-assistant home-assistant bot requested a review from dshokouhi March 22, 2024 10:10
@jpelgrom jpelgrom dismissed dshokouhi’s stale review March 22, 2024 10:49

Review comment applied

@jpelgrom jpelgrom merged commit 588d4cd into home-assistant:master Mar 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants