Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon for pi_hole_v6 #6642

Merged
merged 3 commits into from
Feb 28, 2025
Merged

Conversation

bastgau
Copy link
Contributor

@bastgau bastgau commented Feb 28, 2025

Proposed change

New logo for a custom integration to implement new PiHole V6 API.

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

  • This PR fixes or closes issue: fixes #
  • Link to code base pull request:
  • Link to documentation pull request:
  • Link to integration documentation on our website:
  • Link to custom integration repository: https://github.com/bastgau/ha-pi-hole-v6

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

Thanks

@bastgau bastgau changed the title Upload new logo Add icon for pi_hole_v6 Feb 28, 2025
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @bastgau 👋

Thanks for opening a pull request. However, the provided branding isn't the branding of the service integrated. Please use the original upstream branding, as we do not want to misrepresent an upstream project.

Thanks 👍

../Frenck

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft February 28, 2025 13:29
@bastgau bastgau marked this pull request as ready for review February 28, 2025 21:27
@home-assistant home-assistant bot requested a review from frenck February 28, 2025 21:27
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bastgau 👍

../Frenck

@frenck frenck merged commit 7a562bc into home-assistant:master Feb 28, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants