Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fenecon FEMS / OpenEMS icons and logos #6607

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

Lamarqe
Copy link
Contributor

@Lamarqe Lamarqe commented Feb 21, 2025

Proposed change

As I have implemented an integration for FEMS and OpenEMS systems, I want to contribute the respective logos.

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

  • This PR fixes or closes issue: fixes #
  • Link to code base pull request:
  • Link to documentation pull request:
  • Link to integration documentation on our website:
  • Link to custom integration repository: https://github.com/Lamarqe/ha_openems

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused on what FEMS has to do with this? As OpenEMS seems the thing that is being communicated with?

../Frenck

@home-assistant home-assistant bot marked this pull request as draft February 28, 2025 18:19
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@Lamarqe
Copy link
Contributor Author

Lamarqe commented Feb 28, 2025

Hi Frenck,

Fenecon is the commercial entity whose product is FEMS (Fenecon energy management system).
All major commits to OpenEMS are FEMS backports (check the OpenEMS source code and look at some random git blames).

99% of the user own a FEMS system, not knowing about the open source project. If I only call it OpenEMS, FEMS owner might not find even the HA integration for their system.

There is a similar "Fenecon2Mqtt" addon. It does not even mention OpenEMS, even though it is based on 100% the same (OpenEMS) APIs as what this integration is based on.

I see it comparable as naming something "Chrome", what actually interacts with the "Blink" rendering engine.

Lamarqe

@Lamarqe Lamarqe requested a review from frenck February 28, 2025 19:05
@frenck frenck marked this pull request as ready for review February 28, 2025 19:19
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Lamarqe 👍

../Frenck

@frenck frenck merged commit f91b1b3 into home-assistant:master Feb 28, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants