-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add icon for custom integration ABB Free@Home #5937
Add icon for custom integration ABB Free@Home #5937
Conversation
24ea3fb
to
8092abb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there @kingsleyadam 👋
Thanks for the PR, I do have some things that need to be addressed before this PR can be merged.
The provided branding, is not the branding of ABB, it looks like some kind of sub or product specific branding:
Please use the ABB branding instead.
Additionally, the integration domain provided is abbfreeathome-ci
, however, the use of a dash -
in an integration domain isn't valid. Suggestion is to replace it with an underscore _
instead.
../Frenck
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Thanks for the freedback @frenck! I used the free@home branding since ABB is such a big company with many brands. I'm also good with just using ABB. I've updated the PR to be ABB branding. I've also updated the domain to use an underscore vs a dash both in this PR and my custom integrations repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @kingsleyadam 👍
../Frenck
Proposed change
This adds new icon files for ABB Free@Home Custom Integration.
Type of change
Python wheels repository
Additional information
Checklist
icon.png
)icon@2x.png
)logo.png
)logo@2x.png
)