Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon for custom integration ABB Free@Home #5937

Merged

Conversation

kingsleyadam
Copy link
Contributor

Proposed change

This adds new icon files for ABB Free@Home Custom Integration.

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

@home-assistant home-assistant bot added the Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! label Oct 4, 2024
@kingsleyadam kingsleyadam force-pushed the u/kingsleyadam/addAbbFreeAtHome branch from 24ea3fb to 8092abb Compare October 6, 2024 13:36
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @kingsleyadam 👋

Thanks for the PR, I do have some things that need to be addressed before this PR can be merged.

The provided branding, is not the branding of ABB, it looks like some kind of sub or product specific branding:

CleanShot 2024-10-07 at 09 04 46@2x

Please use the ABB branding instead.

Additionally, the integration domain provided is abbfreeathome-ci, however, the use of a dash - in an integration domain isn't valid. Suggestion is to replace it with an underscore _ instead.

../Frenck

@home-assistant home-assistant bot marked this pull request as draft October 7, 2024 07:06
@home-assistant
Copy link

home-assistant bot commented Oct 7, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@kingsleyadam
Copy link
Contributor Author

Hi there @kingsleyadam 👋

Thanks for the PR, I do have some things that need to be addressed before this PR can be merged.

The provided branding, is not the branding of ABB, it looks like some kind of sub or product specific branding:

CleanShot 2024-10-07 at 09 04 46@2x

Please use the ABB branding instead.

Additionally, the integration domain provided is abbfreeathome-ci, however, the use of a dash - in an integration domain isn't valid. Suggestion is to replace it with an underscore _ instead.

../Frenck

Thanks for the freedback @frenck! I used the free@home branding since ABB is such a big company with many brands. I'm also good with just using ABB. I've updated the PR to be ABB branding.

I've also updated the domain to use an underscore vs a dash both in this PR and my custom integrations repo.

@kingsleyadam kingsleyadam marked this pull request as ready for review October 7, 2024 08:14
@home-assistant home-assistant bot requested a review from frenck October 7, 2024 08:14
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @kingsleyadam 👍

../Frenck

@frenck frenck merged commit 3c946ad into home-assistant:master Oct 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants