Replace checkbox with switch in shortcuts tile name on/off #5009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the settings screen for the shortcuts tile, replace the checkbox with a switch for the option to show names on the tile. A switch is the correct control here instead of a checkbox, because it is a standalone (and the only) option and not something to select in a list. See the Material guidelines: https://m3.material.io/components/switch/guidelines#6add393e-e4e8-41b6-862b-5ebffb894f72.
This PR also removes the checkbox button colors function because this was the last usage of it.
Screenshots
(the preview doesn't render the icon correctly, but that doesn't matter here)
Link to pull request in Documentation repository
n/a
Any other notes