Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run debug builds on master branch pushes #5001

Closed

Conversation

runningcode
Copy link
Contributor

@runningcode runningcode commented Jan 21, 2025

Summary

This runs debug builds on master branch pushes in order to populate the
github actions cache via the Gradle build action for faster PR builds. Future no-op builds should be significantly faster!
By default the Gradle build action writes to the caches on master branch builds. Other branches read from the master branch cache or their own branch cache. Here is more information on branch caching.
I'm assuming that since this is an OSS project the github action runners
are free so there is no cost to this.

I also renamed pr_build to build to reflect this change but that means that the required status check has been renamed.

This runs debug builds on master branch pushes in order to populate the
github actions cache via the Gradle build action for faster PR builds.
I'm assuming that since this is an OSS project the github action runners
are free so there is no cost to this.
@jpelgrom
Copy link
Member

This action also generates debug apk files and uploads them as an artifact, which we don't need. The entire workflow is named pull request and also does lint checks which are unnecessary after merging.

Maybe some resources could be saved by just creating a new, simple job in the master push workflow?

I'm assuming that since this is an OSS project the github action runners are free so there is no cost to this.

I believe so but that doesn't mean we should do more work that isn't used

@runningcode
Copy link
Contributor Author

I spent some time debugging the slow builds and lack of caching by running some tests in my fork. The lack of caching is due to the timestamped versionnames and version codes used in every module. Nothing can be retrieved from the cach because of that and the reckon gradle plugin unfortunately so it doesn’t make sense to make this change.

@runningcode runningcode deleted the no/populate-cache branch January 22, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants