Add notification command for turning the flashlight on/off

[marazmarci]

Summary

I added the command_flashlight notification command. It accepts two values in the command field: turn_on or turn_off.

Currently, my implementation only supports API 23 and above, while the app has minSdkVersion = 21. The main reason is my laziness lack of time, and because the Camera2 API is available starting from API 23, and I haven't found a trivial ...Compat solution. If someone mentions needing this on API 21-22, it can be implemented as a separate feature request. Please let me know if this approach is OK for you.

The PR is marked as a draft because I still have to implement requesting the Camera permission, but I first wanted to ask for your advice on it. The problem is that in MessagingManager only so-called "special permissions" are being requested, and there are no runtime permissions, and it would require an Activity. I thought of adding another registerForActivityResult(ActivityResultContracts.RequestPermission()) in BaseActivity and making BaseActivity subscribe to an event-like Flow from a singleton class, which would trigger a permission request, and MessagingManager could trigger this event. WDYT?

Related feature request: #1606

Screenshots

N/A

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#1131

Any other notes

Future improvement possibilities:

• Support API 21 and 22
• Add command: toggle
• Add a binary_sensor representing the current state of the torch (maybe even a light entity?)
• Add torch strength control

[dshokouhi]

The problem is that in MessagingManager there are only so-called "special permissions" being requested, and there are no runtime permissions,

we actually request the phone permission for one specific intent I think you can use the same method. Take user to webview, then they grant the permission and try again.

https://github.com/home-assistant/android/blob/master/app/src/main/java/io/homeassistant/companion/android/notifications/MessagingManager.kt#L689-L697

(maybe even a light entity?)

this would require HA core changes, we dont have any controllable entities and have not discussed about how it should work. Think this probably requires an arch discussion.

[marazmarci]

I created a PR in the documentation repository: home-assistant/companion.home-assistant#1131

[dshokouhi]

Can you please submit a PR to the mobile app FCM repo adding the new command to the list commands so it can be excluded from the rate limit?

https://github.com/home-assistant/mobile-apps-fcm-push/blob/main/functions/android.js#L70-L74

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

[dshokouhi]

Tested debug APK and works as expected