Fix target temperature step attribute name error #4039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix wrong attribute name for the target temperature step. Correct one is target_temp_step (which is returned by the API) instead of target_temperature_step
dshokouhi
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Looks good to me, thanks for the fix!
This is indeed correct and for quite sometime when looking at the HA core code
https://github.com/home-assistant/core/blob/dev/homeassistant/components/climate/const.py#L130
JBassett
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix wrong attribute name for the target temperature step.
Correct one is target_temp_step (which is returned by the API) instead of target_temperature_step.
Currently it is not possible to adjust the temperature of a thermostat in the Android device controls to a step size smaller than 1.