Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

letsencrypt: Add Infomaniak DNS provider #3320

Merged
merged 1 commit into from
Dec 9, 2023
Merged

letsencrypt: Add Infomaniak DNS provider #3320

merged 1 commit into from
Dec 9, 2023

Conversation

davidebeatrici
Copy link
Contributor

home-assistant[bot]
home-assistant bot previously requested changes Nov 18, 2023
View reviewed changes
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @davidebeatrici

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot marked this pull request as draft November 18, 2023 22:59
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@davidebeatrici davidebeatrici marked this pull request as ready for review November 18, 2023 23:00
sairon
sairon requested changes Dec 8, 2023
View reviewed changes
Copy link
Member

@sairon sairon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add info to the readme, like we have for the other DNS plugins, and update the PR branch with changes from the current master?

@home-assistant home-assistant bot marked this pull request as draft December 8, 2023 11:30
@davidebeatrici
Copy link
Contributor Author

Done.

@davidebeatrici davidebeatrici marked this pull request as ready for review December 8, 2023 22:11
@home-assistant home-assistant bot requested a review from sairon December 8, 2023 22:11
@sairon sairon merged commit b217bb6 into home-assistant:master Dec 9, 2023
@davidebeatrici davidebeatrici deleted the letsencrypt-infomaniak branch December 9, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sairon sairon sairon approved these changes

@home-assistant home-assistant[bot] home-assistant[bot] left review comments

Assignees
No one assigned
Labels
add-on: letsencrypt cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidebeatrici @sairon @agners