letsencrypt: Add desec.io support DNS challenge #3157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @henrikhierl It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
home-assistant
bot
added
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
mdegat01
requested changes
Sep 1, 2023
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
+1 to getting this PR merged. 🙏🏽 |
|
@henrikhierl the add-on now got updated to the latest Alpine version etc. Can resolve the merge conflict and add the version bump to the changelog and config.yaml (similar to how #3152 was done)? Then we should be able to merge this soon. |
henrikhierl
force-pushed
the
add_letsencrypt_desec_support
branch
from
1cb93b5 to
24159fa
Compare
|
@agners just rebased the branch and add the version bump to the changelog and config.yaml |
agners
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.