Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samba: Decrease Samba log level #3002

Merged
merged 8 commits into from
Nov 29, 2023
Merged

samba: Decrease Samba log level #3002

merged 8 commits into from
Nov 29, 2023

Conversation

lmagyar
Copy link
Contributor

@lmagyar lmagyar commented Apr 22, 2023

Just a small improvement.

Samba default log level is 1, currently the add-on's samba log level is 2, this PR makes it to follow the add-on log_level.

frenck
frenck approved these changes Apr 22, 2023
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should add more options, in general, we should reduce options.

As part of the efforts described in #2997, I've been lowering the log level by default (as health checks would make it verbose).

See also my comments on your other PR #3001

../Frenck

frenck
frenck requested changes Apr 22, 2023
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry didn't mean to approve it, wrong button.

@home-assistant home-assistant bot marked this pull request as draft April 22, 2023 11:26
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@lmagyar lmagyar mentioned this pull request Apr 22, 2023
Merged
@github-actions github-actions bot added stale and removed stale labels Jul 3, 2023
@github-actions github-actions bot added the stale label Sep 24, 2023
@github-actions github-actions bot closed this Oct 1, 2023
@lmagyar
Copy link
Contributor Author

lmagyar commented Oct 1, 2023

Can be reopened, github actions bot didn't send notification about the stale label on this draft PR, only when closed it.

@agners agners reopened this Oct 2, 2023
@github-actions github-actions bot removed the stale label Oct 2, 2023
@agners
Copy link
Member

agners commented Nov 24, 2023

@lmagyar this looks quite good to me, is there a reason this is still in draft currently?

@lmagyar
Copy link
Contributor Author

lmagyar commented Nov 24, 2023

Technically no reason to be draft, I've rebased and made it non-draft.

Though Frenck do not prefer adding more options.

I don't think we should add more options, in general, we should reduce options.

As part of the efforts described in #2997, I've been lowering the log level by default (as health checks would make it verbose).

See also my comments on your other PR #3001

Currently the default samba log-level is still 2, so currently it is still chatty. Maybe after adding health checks he forgot to decrease this to 1. So maybe a simple 1 character change is preferred by him. I don't know, I'm just guessing.

@lmagyar lmagyar marked this pull request as ready for review November 24, 2023 10:12
@home-assistant home-assistant bot requested a review from frenck November 24, 2023 10:12
@frenck
Copy link
Member

frenck commented Nov 27, 2023

So maybe a simple 1 character change is preferred by him. I don't know, I'm just guessing.

Yeah I would agree on doing that tbh 👍

@lmagyar
Copy link
Contributor Author

lmagyar commented Nov 28, 2023

Done:

  • reverted the configurability changes
  • decreased samla log level from 2 to 1
  • rebased

frenck
frenck approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @lmagyar 👍

../Frenck

@frenck frenck merged commit d83ee07 into home-assistant:master Nov 29, 2023
9 checks passed
@lmagyar lmagyar deleted the pr-samba-log-level branch November 30, 2023 07:30
@lmagyar lmagyar changed the title samba: Make Samba log level configurable samba: Decrease Samba log level Dec 8, 2023
danveitch76 added a commit to danveitch76/hassio-addons that referenced this pull request Feb 23, 2024
@danveitch76
Update SambaNAS to v12.2.0-nas1a
9d8a69f 
## 12.2.0-nas1a

###  ✨ Features
- New `mqtt_nexgen_entities` option and scripts to enable new MQTT integration. This will be the default system for future integration is more efficent and use less resources but now is **Experimental**
- `automount` now see also APFS drivers
- Support reuse names from reserved share disabled  (for [#188](dianlight/hassio-addons#188))
- Move addon config in `addons_config`
- Homeassitant Automount also with different user in acl
- ✨ [REQUEST] Support for APFS formatted hard drives [#184](dianlight/hassio-addons#184) - Only ReadOnly for now
- Added mount options default is set to 'nosuid,relatime,noexec' [cherry pick from PR#167] ([DOCS.md][docs])
- Added filter for reserved sharenames (config addons ssl share backup media) [cherry pick from PR#167]

### 💥 BREAKING CHANGE
- Removed deprecated `mqtt_use_legacy_entities` option and scripts.
- Drop support for `armhf` and `i386`
- "vfat" "msdos" "f2fs" "fuseblk" and "exfat" are now marked unsupported for timemachine.
- Internal HA Storage Mount is done with a generated superuser

###  🩹 BugFix
- 🐛 [Samba NAS] Auto mount fails afterupgrade to 12.1.0-nas [#181](dianlight/hassio-addons#181)
- SambaNAS - error after update /etc/s6-overlay/s6-rc.d/init-samba/run: line 47: /tmp/local_mount.json: No such file or directory [#194](dianlight/hassio-addons#194)
- 🐛 [SambaNAS] Can't mount moredisks with label that contains a reserved word as substring [#188](dianlight/hassio-addons#188)
- 🐛 [sambanas] 0x80070032 The request is not supported [#182](dianlight/hassio-addons#182)
- 🐛 [SAMBA NAS] Unable to upload or rename files in external usb  [#171](dianlight/hassio-addons#171)
- 🐛 [SAMBA NAS] Getting error 100093 when trying to add a file via SMB on an external exFat disk attached to the pi [#175](dianlight/hassio-addons#175)
- Fix mount concurrency. Solve some issue on addon-restart. (try to resolve [#159](dianlight/hassio-addons#159))

### 🏗 Chore
- [Full Changelog from official addon 12.2.0][changelog_12.2.0]
  - Decrease Samba log level (Skipped. Loglevel is configurable)
- Update Based Image to 15.0.3 (Alpine 3.19.0)

### 🧪 Experimental
- Rework on all MQTT client implementation. [In Progress]
- [Full Changelog from official addon 12.1.0][changelog_12.1.0]
  - Use the new Home Assistant folder for the config share
  - Add support for accessing public add-on configurations
- [Full Changelog from official addon 12.0.0][changelog_12.0.0]
  - Adjust location of Home Assistant config to match latest dev/beta Supervisor
- [Full Changelog from official addon 11.0.0][changelog_11.0.0]
  - Add support for accessing public add-on configurations
  - Update Based Image to 14.3.2 (Alpine 3.18.4)
  - Adds HEALTCHECK support
- [Full Changelog from official addon 10.0.2][changelog_10.0.2]
  - Already Implemented: Enable IPv6 ULA and IPv4 link-local addresses by default

[changelog_12.1.0]: home-assistant/addons#3312
[changelog_12.0.0]: home-assistant/addons#3311
[changelog_11.1.0]: home-assistant/addons#3001
[changelog_11.0.0]: home-assistant/addons#3297
[changelog_10.0.2]: home-assistant/addons#3062
[changelog_10.0.1]: home-assistant/addons#2997
[changelog_12.2.0]: home-assistant/addons#3002
danveitch76 added a commit to danveitch76/hassio-addons that referenced this pull request Feb 23, 2024
@danveitch76
Update SambaNAS to v12.2.0-nas1a
2e49390 
- New `mqtt_nexgen_entities` option and scripts to enable new MQTT integration. This will be the default system for future integration is more efficent and use less resources but now is **Experimental**
- `automount` now see also APFS drivers
- Support reuse names from reserved share disabled  (for [#188](dianlight/hassio-addons#188))
- Move addon config in `addons_config`
- Homeassitant Automount also with different user in acl
- ✨ [REQUEST] Support for APFS formatted hard drives [#184](dianlight/hassio-addons#184) - Only ReadOnly for now
- Added mount options default is set to 'nosuid,relatime,noexec' [cherry pick from PR#167] ([DOCS.md][docs])
- Added filter for reserved sharenames (config addons ssl share backup media) [cherry pick from PR#167]

- Removed deprecated `mqtt_use_legacy_entities` option and scripts.
- Drop support for `armhf` and `i386`
- "vfat" "msdos" "f2fs" "fuseblk" and "exfat" are now marked unsupported for timemachine.
- Internal HA Storage Mount is done with a generated superuser

- 🐛 [SambaNAS] Auto mount fails afterupgrade to 12.1.0-nas [#181](dianlight/hassio-addons#181)
- 🐛 [SambaNAS] - error after update /etc/s6-overlay/s6-rc.d/init-samba/run: line 47: /tmp/local_mount.json: No such file or directory [#194](dianlight/hassio-addons#194)
- 🐛 [SambaNAS] Can't mount moredisks with label that contains a reserved word as substring [#188](dianlight/hassio-addons#188)
- 🐛 [SambaNAS] 0x80070032 The request is not supported [#182](dianlight/hassio-addons#182)
- 🐛 [SambaNAS] Unable to upload or rename files in external usb  [#171](dianlight/hassio-addons#171)
- 🐛 [SambaNAS] Getting error 100093 when trying to add a file via SMB on an external exFat disk attached to the pi [#175](dianlight/hassio-addons#175)
- 🐛 [SambaNAS] Fix mount concurrency. Solve some issue on addon-restart. (try to resolve [#159](dianlight/hassio-addons#159))
- 🐛 [SambaNAS] Changing file permissions on SambaNAS

- [Full Changelog from official addon 12.2.0][changelog_12.2.0]
  - Decrease Samba log level (Skipped. Loglevel is configurable)
- Update Based Image to 15.0.3 (Alpine 3.19.0)

- Rework on all MQTT client implementation. [In Progress]
- [Full Changelog from official addon 12.1.0][changelog_12.1.0]
  - Use the new Home Assistant folder for the config share
  - Add support for accessing public add-on configurations
- [Full Changelog from official addon 12.0.0][changelog_12.0.0]
  - Adjust location of Home Assistant config to match latest dev/beta Supervisor
- [Full Changelog from official addon 11.0.0][changelog_11.0.0]
  - Add support for accessing public add-on configurations
  - Update Based Image to 14.3.2 (Alpine 3.18.4)
  - Adds HEALTCHECK support
- [Full Changelog from official addon 10.0.2][changelog_10.0.2]
  - Already Implemented: Enable IPv6 ULA and IPv4 link-local addresses by default

[changelog_12.1.0]: home-assistant/addons#3312
[changelog_12.0.0]: home-assistant/addons#3311
[changelog_11.1.0]: home-assistant/addons#3001
[changelog_11.0.0]: home-assistant/addons#3297
[changelog_10.0.2]: home-assistant/addons#3062
[changelog_10.0.1]: home-assistant/addons#2997
[changelog_12.2.0]: home-assistant/addons#3002
danveitch76 added a commit to danveitch76/hassio-addons that referenced this pull request Feb 23, 2024
@danveitch76
Update SambaNAS to v12.2.0-nas1a
33bf8d4 
- New `mqtt_nexgen_entities` option and scripts to enable new MQTT integration. This will be the default system for future integration is more efficent and use less resources but now is **Experimental**
- `automount` now see also APFS drivers
- Support reuse names from reserved share disabled  (for [#188](dianlight/hassio-addons#188))
- Move addon config in `addons_config`
- Homeassitant Automount also with different user in acl
- ✨ [REQUEST] Support for APFS formatted hard drives [#184](dianlight/hassio-addons#184) - Only ReadOnly for now
- Added mount options default is set to 'nosuid,relatime,noexec' [cherry pick from PR#167] ([DOCS.md][docs])
- Added filter for reserved sharenames (config addons ssl share backup media) [cherry pick from PR#167]

- Removed deprecated `mqtt_use_legacy_entities` option and scripts.
- Drop support for `armhf` and `i386`
- "vfat" "msdos" "f2fs" "fuseblk" and "exfat" are now marked unsupported for timemachine.
- Internal HA Storage Mount is done with a generated superuser

- 🐛 [SambaNAS] Auto mount fails afterupgrade to 12.1.0-nas [#181](dianlight/hassio-addons#181)
- 🐛 [SambaNAS] - error after update /etc/s6-overlay/s6-rc.d/init-samba/run: line 47: /tmp/local_mount.json: No such file or directory [#194](dianlight/hassio-addons#194)
- 🐛 [SambaNAS] Can't mount moredisks with label that contains a reserved word as substring [#188](dianlight/hassio-addons#188)
- 🐛 [SambaNAS] 0x80070032 The request is not supported [#182](dianlight/hassio-addons#182)
- 🐛 [SambaNAS] Unable to upload or rename files in external usb  [#171](dianlight/hassio-addons#171)
- 🐛 [SambaNAS] Getting error 100093 when trying to add a file via SMB on an external exFat disk attached to the pi [#175](dianlight/hassio-addons#175)
- 🐛 [SambaNAS] Fix mount concurrency. Solve some issue on addon-restart. (try to resolve [#159](dianlight/hassio-addons#159))
- 🐛 [SambaNAS] Changing file permissions on SambaNAS

- [Full Changelog from official addon 12.2.0][changelog_12.2.0]
  - Decrease Samba log level (Skipped. Loglevel is configurable)
- Update Based Image to 15.0.3 (Alpine 3.19.0)

- Rework on all MQTT client implementation. [In Progress]
- [Full Changelog from official addon 12.1.0][changelog_12.1.0]
  - Use the new Home Assistant folder for the config share
  - Add support for accessing public add-on configurations
- [Full Changelog from official addon 12.0.0][changelog_12.0.0]
  - Adjust location of Home Assistant config to match latest dev/beta Supervisor
- [Full Changelog from official addon 11.0.0][changelog_11.0.0]
  - Add support for accessing public add-on configurations
  - Update Based Image to 14.3.2 (Alpine 3.18.4)
  - Adds HEALTCHECK support
- [Full Changelog from official addon 10.0.2][changelog_10.0.2]
  - Already Implemented: Enable IPv6 ULA and IPv4 link-local addresses by default

[changelog_12.1.0]: home-assistant/addons#3312
[changelog_12.0.0]: home-assistant/addons#3311
[changelog_11.1.0]: home-assistant/addons#3001
[changelog_11.0.0]: home-assistant/addons#3297
[changelog_10.0.2]: home-assistant/addons#3062
[changelog_10.0.1]: home-assistant/addons#2997
[changelog_12.2.0]: home-assistant/addons#3002
danveitch76 added a commit to danveitch76/hassio-addons that referenced this pull request Feb 23, 2024
@danveitch76
Update SambaNAS to v12.2.0-nas1a
91e2bed 
- New `mqtt_nexgen_entities` option and scripts to enable new MQTT integration. This will be the default system for future integration is more efficent and use less resources but now is **Experimental**
- `automount` now see also APFS drivers
- Support reuse names from reserved share disabled  (for [#188](dianlight/hassio-addons#188))
- Move addon config in `addons_config`
- Homeassitant Automount also with different user in acl
- ✨ [REQUEST] Support for APFS formatted hard drives [#184](dianlight/hassio-addons#184) - Only ReadOnly for now
- Added mount options default is set to 'nosuid,relatime,noexec' [cherry pick from PR#167] ([DOCS.md][docs])
- Added filter for reserved sharenames (config addons ssl share backup media) [cherry pick from PR#167]

- Removed deprecated `mqtt_use_legacy_entities` option and scripts.
- Drop support for `armhf` and `i386`
- "vfat" "msdos" "f2fs" "fuseblk" and "exfat" are now marked unsupported for timemachine.
- Internal HA Storage Mount is done with a generated superuser

- 🐛 [SambaNAS] Auto mount fails afterupgrade to 12.1.0-nas [#181](dianlight/hassio-addons#181)
- 🐛 [SambaNAS] - error after update /etc/s6-overlay/s6-rc.d/init-samba/run: line 47: /tmp/local_mount.json: No such file or directory [#194](dianlight/hassio-addons#194)
- 🐛 [SambaNAS] Can't mount moredisks with label that contains a reserved word as substring [#188](dianlight/hassio-addons#188)
- 🐛 [SambaNAS] 0x80070032 The request is not supported [#182](dianlight/hassio-addons#182)
- 🐛 [SambaNAS] Unable to upload or rename files in external usb  [#171](dianlight/hassio-addons#171)
- 🐛 [SambaNAS] Getting error 100093 when trying to add a file via SMB on an external exFat disk attached to the pi [#175](dianlight/hassio-addons#175)
- 🐛 [SambaNAS] Fix mount concurrency. Solve some issue on addon-restart. (try to resolve [#159](dianlight/hassio-addons#159))
- 🐛 [SambaNAS] Changing file permissions on SambaNAS

- [Full Changelog from official addon 12.2.0][changelog_12.2.0]
  - Decrease Samba log level (Skipped. Loglevel is configurable)
- Update Based Image to 15.0.3 (Alpine 3.19.0)

- Rework on all MQTT client implementation. [In Progress]
- [Full Changelog from official addon 12.1.0][changelog_12.1.0]
  - Use the new Home Assistant folder for the config share
  - Add support for accessing public add-on configurations
- [Full Changelog from official addon 12.0.0][changelog_12.0.0]
  - Adjust location of Home Assistant config to match latest dev/beta Supervisor
- [Full Changelog from official addon 11.0.0][changelog_11.0.0]
  - Add support for accessing public add-on configurations
  - Update Based Image to 14.3.2 (Alpine 3.18.4)
  - Adds HEALTCHECK support
- [Full Changelog from official addon 10.0.2][changelog_10.0.2]
  - Already Implemented: Enable IPv6 ULA and IPv4 link-local addresses by default

[changelog_12.1.0]: home-assistant/addons#3312
[changelog_12.0.0]: home-assistant/addons#3311
[changelog_11.1.0]: home-assistant/addons#3001
[changelog_11.0.0]: home-assistant/addons#3297
[changelog_10.0.2]: home-assistant/addons#3062
[changelog_10.0.1]: home-assistant/addons#2997
[changelog_12.2.0]: home-assistant/addons#3002
danveitch76 added a commit to danveitch76/dianlight-sambanas that referenced this pull request Feb 25, 2024
@danveitch76
Update to v10.0.2-nas4c
b5cc73c 
## 10.0.2-nas4c

###  ✨ Features
- Move addon config in `addons_config`
- Move homeassistant config in `homeassistant_config`

### 💥 BREAKING CHANGE
- Drop support for `armhf` and `i386`
- **This is the last version with** `mqtt_use_legacy_entities`. Legacy implementation will be removed in next version.

### 🏗 Chore
- [Full Changelog from official addon 12.1.0][changelog_12.1.0]
  - Use the new Home Assistant folder for the config share
  - Add support for accessing public add-on configurations
- [Full Changelog from official addon 12.0.0][changelog_12.0.0]
  - Adjust location of Home Assistant config to match latest dev/beta Supervisor
- [Full Changelog from official addon 11.0.0][changelog_11.0.0]
  - Add support for accessing public add-on configurations
  - Update Based Image to 14.3.2 (Alpine 3.18.4)
  - Adds HEALTCHECK support
- [Full Changelog from official addon 10.0.2][changelog_10.0.2]
  - Already Implemented: Enable IPv6 ULA and IPv4 link-local addresses by default

###  🩹 BugFix

[changelog_12.1.0]: home-assistant/addons#3312
[changelog_12.0.0]: home-assistant/addons#3311
[changelog_11.1.0]: home-assistant/addons#3001
[changelog_11.0.0]: home-assistant/addons#3297
[changelog_10.0.2]: home-assistant/addons#3062
[changelog_10.0.1]: home-assistant/addons#2997
[changelog_12.2.0]: home-assistant/addons#3002
danveitch76 added a commit to danveitch76/hassio-addons that referenced this pull request Feb 25, 2024
@danveitch76
Update SambaNAS to v10.0.2-nas4c
02807da 
- Move addon config in `addons_config`
- Move homeassistant config in `homeassistant_config`

- Drop support for `armhf` and `i386`
- **This is the last version with** `mqtt_use_legacy_entities`. Legacy implementation will be removed in next version.

- [Full Changelog from official addon 12.1.0][changelog_12.1.0]
  - Use the new Home Assistant folder for the config share
  - Add support for accessing public add-on configurations
- [Full Changelog from official addon 12.0.0][changelog_12.0.0]
  - Adjust location of Home Assistant config to match latest dev/beta Supervisor
- [Full Changelog from official addon 11.0.0][changelog_11.0.0]
  - Add support for accessing public add-on configurations
  - Update Based Image to 14.3.2 (Alpine 3.18.4)
  - Adds HEALTCHECK support
- [Full Changelog from official addon 10.0.2][changelog_10.0.2]
  - Already Implemented: Enable IPv6 ULA and IPv4 link-local addresses by default

[changelog_12.1.0]: home-assistant/addons#3312
[changelog_12.0.0]: home-assistant/addons#3311
[changelog_11.1.0]: home-assistant/addons#3001
[changelog_11.0.0]: home-assistant/addons#3297
[changelog_10.0.2]: home-assistant/addons#3062
[changelog_10.0.1]: home-assistant/addons#2997
[changelog_12.2.0]: home-assistant/addons#3002
danveitch76 added a commit to danveitch76/hassio-addons that referenced this pull request Feb 25, 2024
@danveitch76
Update SambaNAS to v10.0.2-nas4c
bd59936 
## 10.0.2-nas4c

###  ✨ Features
- Move addon config in `addons_config`
- Move homeassistant config in `homeassistant_config`

### 💥 BREAKING CHANGE
- Drop support for `armhf` and `i386`
- **This is the last version with** `mqtt_use_legacy_entities`. Legacy implementation will be removed in next version.

### 🏗 Chore
- [Full Changelog from official addon 12.1.0][changelog_12.1.0]
  - Use the new Home Assistant folder for the config share
  - Add support for accessing public add-on configurations
- [Full Changelog from official addon 12.0.0][changelog_12.0.0]
  - Adjust location of Home Assistant config to match latest dev/beta Supervisor
- [Full Changelog from official addon 11.0.0][changelog_11.0.0]
  - Add support for accessing public add-on configurations
  - Update Based Image to 14.3.2 (Alpine 3.18.4)
  - Adds HEALTCHECK support
- [Full Changelog from official addon 10.0.2][changelog_10.0.2]
  - Already Implemented: Enable IPv6 ULA and IPv4 link-local addresses by default

###  🩹 BugFix

[changelog_12.1.0]: home-assistant/addons#3312
[changelog_12.0.0]: home-assistant/addons#3311
[changelog_11.1.0]: home-assistant/addons#3001
[changelog_11.0.0]: home-assistant/addons#3297
[changelog_10.0.2]: home-assistant/addons#3062
[changelog_10.0.1]: home-assistant/addons#2997
[changelog_12.2.0]: home-assistant/addons#3002
danveitch76 added a commit to danveitch76/hassio-addons that referenced this pull request Feb 25, 2024
@danveitch76
Update SambaNAS to v10.0.2-nas4c
3756327 
## 10.0.2-nas4c

###  ✨ Features
- Move addon config in `addons_config`
- Move homeassistant config in `homeassistant_config`

### 💥 BREAKING CHANGE
- Drop support for `armhf` and `i386`
- **This is the last version with** `mqtt_use_legacy_entities`. Legacy implementation will be removed in next version.

### 🏗 Chore
- [Full Changelog from official addon 12.1.0][changelog_12.1.0]
  - Use the new Home Assistant folder for the config share
  - Add support for accessing public add-on configurations
- [Full Changelog from official addon 12.0.0][changelog_12.0.0]
  - Adjust location of Home Assistant config to match latest dev/beta Supervisor
- [Full Changelog from official addon 11.0.0][changelog_11.0.0]
  - Add support for accessing public add-on configurations
  - Update Based Image to 14.3.2 (Alpine 3.18.4)
  - Adds HEALTCHECK support
- [Full Changelog from official addon 10.0.2][changelog_10.0.2]
  - Already Implemented: Enable IPv6 ULA and IPv4 link-local addresses by default

###  🩹 BugFix

[changelog_12.1.0]: home-assistant/addons#3312
[changelog_12.0.0]: home-assistant/addons#3311
[changelog_11.1.0]: home-assistant/addons#3001
[changelog_11.0.0]: home-assistant/addons#3297
[changelog_10.0.2]: home-assistant/addons#3062
[changelog_10.0.1]: home-assistant/addons#2997
[changelog_12.2.0]: home-assistant/addons#3002
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frenck frenck frenck approved these changes

@agners agners agners approved these changes

Assignees
No one assigned
Labels
add-on: samba cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lmagyar @agners @frenck