Fixing device.py so that Travis doesn't fail and added test #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 28, 2017
tests/test_light.py
Outdated
| @@ -227,3 +227,12 @@ def test_color_device_control(): | |||
| assert light_control.can_set_kelvin | |||
| assert light_control.min_kelvin == 1667 | |||
| assert light_control.max_kelvin == 25000 | |||
|
|
|||
| def test_setters(): | |||
houndci-bot
reviewed
Oct 28, 2017
tests/test_light.py
Outdated
| @@ -227,3 +227,12 @@ def test_color_device_control(): | |||
| assert light_control.can_set_kelvin | |||
| assert light_control.min_kelvin == 1667 | |||
| assert light_control.max_kelvin == 25000 | |||
|
|
|||
| def test_setters(): | |||
|
@balloob created a new, clean, branch with minimum commits |
balloob
reviewed
Oct 28, 2017
| return self.set_hex_color(color, index=index) | ||
| except KeyError: |
There was a problem hiding this comment.
I don't like swallowing errors. Because now as a caller, I won't know if my call succeeded and that means that I can't communicate this to my users. I think that we should never catch but instead raise as much as possible. That way we leave it to developers that use this lib if they want to swallow errors or show them to users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current prod version of the code, Travis throws an error in device.py (#76). Oddly, the error wasn't there when the affected lines of code was first merged. This is a fix for that error so that Travis can build again. I've also added a test for the set_predefined_color-method.