-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add set_repeat_days to SmartTask #615
Add set_repeat_days to SmartTask #615
Conversation
In response to "We don't use the const module above. I think we should be consistent", I think having symbolic names for the individual days is critical as a disambiguation, since " |
Actually, I didn't see |
print("> from pytradfri.const.Days import TUESDAY, THURSDAY, SATURDAY, SUNDAY") | ||
print("> days = TUESDAY | THURSDAY | SATURDAY | SUNDAY") | ||
print("> api(socket.socket_control.set_repeat_days(days))") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would avoid the modification to const.py
:
print("> from pytradfri.const.Days import TUESDAY, THURSDAY, SATURDAY, SUNDAY") | |
print("> days = TUESDAY | THURSDAY | SATURDAY | SUNDAY") | |
print("> api(socket.socket_control.set_repeat_days(days))") | |
print("> from pytradfri.smart_task import WEEKDAYS") | |
print("> days = WEEKDAYS.tue | WEEKDAYS.thur | WEEKDAYS.sat | WEEKDAYS.sun") | |
print("> api(socket.socket_control.set_repeat_days(days))") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the existing constant in smart_task
.
Days
with constants intoconst.py
TaskControl.set_repeat_days
for SmartTasklights
to the onboarding helper textsockets
andsocket
to__main__
set_repeat_days
in__main__