Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add combine commands to light control #512

Merged
merged 2 commits into from
Jun 24, 2022

Conversation

MartinHjelmare
Copy link
Contributor

@MartinHjelmare MartinHjelmare commented Jun 23, 2022

  • Some light bulbs support receiving multiple light data items in the same command, eg dimmer and hsb color or dimmer and color temp.
  • Add back a way for the library user to combine light control commands into one command with merged data.
  • We removed the general way to merge commands previously as it is complicated to support the general case. There's also no known real use case for combining other commands than light control commands.
  • We still have the attribute LightControl.can_combine_commands so it makes sense to have a method LightControl.combine_commands.

Copy link
Member

@ggravlingen ggravlingen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 2583b53 into master Jun 24, 2022
@MartinHjelmare MartinHjelmare deleted the add-light-control-combine-command branch June 24, 2022 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants